146 check hardcoded value before publish repo to public#147
Merged
LuernOutOfOrder merged 3 commits intodevelopfrom Jun 8, 2025
Merged
Conversation
LuernOutOfOrder
added
the
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s licensing from a restrictive proprietary notice to a custom open-source NYX License v1.0 and adds a corresponding License section in the README.
- Replaces old restrictive license with NYX License v1.0 in
LICENSE - Adds a “License” section to
README.mdsummarizing the new terms
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Added License section and link to license file |
| LICENSE | Introduced NYX License v1.0, replacing previous notice |
Comments suppressed due to low confidence (2)
README.md:52
- [nitpick] The README refers to the "NYX Custom License" while the LICENSE file names it "NYX License v1.0 (Custom)"; consider aligning naming for clarity.
This project is licensed under the NYX Custom License.
LICENSE:15
- [nitpick] The author name in the new license differs from the original repository owner; ensure the copyright holder is correct and consistent.
Copyright (c) 2025 Luern
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LuernOutOfOrder
deleted the
146-check-hardcoded-value-before-publish-repo-to-public
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the licensing terms for the project, transitioning to a custom open-source license (NYX License v1.0) that allows non-commercial use, modification, and redistribution with attribution. The
LICENSEfile has been rewritten, and theREADME.mdfile has been updated to reflect the new license.Licensing updates:
LICENSE: Replaced the previous restrictive copyright notice with the NYX License v1.0, which permits non-commercial use, modification, and redistribution with attribution, while prohibiting commercial use and sublicensing.README.md: Added a "License" section summarizing the terms of the NYX License and linking to theLICENSE.mdfile for full details.