Fix git pull and improve upgrade#154
Merged
LuernOutOfOrder merged 3 commits intodevelopfrom Jun 20, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the
git_pullfunction insrc/git/mod.rsto enhance error handling and output management, along with minor adjustments to theupgrade_binfunction insrc/upgrade/mod.rsto reorder operations for better user feedback.Improvements to
git_pullfunction:git_pullfunction to useStdio::piped()for capturing output and replacedwait()withwait_with_output()to handle both the status and output of the command. This improves error handling and provides more flexibility for processing command output. (src/git/mod.rs, src/git/mod.rsR141-R151)Stdiofromstd::processto support the changes ingit_pull. (src/git/mod.rs, src/git/mod.rsL1-R1)Adjustments to
upgrade_binfunction:git_pullcall inupgrade_binto execute before starting the throbber, ensuring that the repository pull process is clearly communicated to the user before the progress indicator begins. (src/upgrade/mod.rs, src/upgrade/mod.rsR20-R21)git_pullcall inupgrade_binwith a new placement, aligning with the updated workflow. (src/upgrade/mod.rs, src/upgrade/mod.rsL11)