Support panic backtraces, add log buffer #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test fails there is no way to use RUST_BACKTRACE=1 to show a backtrace. This patch fixes the issue. Additionally, it adds an explicit log buffer that can be used to work around LukasKalbertodt#9. That's a feature that the std harness doesn't have, but I think it's appropriate to add since it's a workaround for something libtest-mimic _doesn't_ but should have.
Author
|
it seems this codebase doesn't pass through |
Author
|
hey @LukasKalbertodt do you have time to review this PR? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test fails there is no way to use RUST_BACKTRACE=1 to show a
backtrace. This patch fixes the issue.
Additionally, it adds an explicit log buffer that can be used to work
around #9. That's a feature that the std harness doesn't have, but I
think it's appropriate to add since it's a workaround for something
libtest-mimic doesn't but should have (stdout/err capturing)