Provide a mechanism to skip tests at runtime #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runner will inspect Ok values to determine if the test should be
ignored ("skipped" for our purposes means runtime ignore). This can be
seem in terse or json output directly.
Co-authored-by: Ben Widawsky <ben@bwidawsk.net>
Fixes: LukasKalbertodt#19
(Most of this is from Ben, I just updated the types)
tgross35
force-pushed
the
runtime-skip
branch
from
b509236 to
513d7f7
Compare
Co-authored-by: Ben Widawsky <ben@bwidawsk.net> (most of this is from Ben)
tgross35
force-pushed
the
runtime-skip
branch
from
513d7f7 to
4c8413b
Compare
Open
|
This PR would be very useful in probe-rs. The project (among other things) runs tests on embedded devices, and libtest-mimic just orchestrates and provides the output. We allow aborting a test run with ctrl-c, but we do it by aborting the process, which causes some problems with some devices. This PR would allow us to more gracefully exit. |
Author
|
@LukasKalbertodt would you be able to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #38 (cc @bwidawsk) with the following changes:
Option<String>to a custom enumlibtestwhen#[ignore = "foo"]is usedFixes #19