Skip to content

Fixed ICA test reliability, simplified Dockerfile, and added CI workflow#1

Merged
akobrin1 merged 1 commit intomasterfrom
ica-fixes
Feb 16, 2026
Merged

Fixed ICA test reliability, simplified Dockerfile, and added CI workflow#1
akobrin1 merged 1 commit intomasterfrom
ica-fixes

Conversation

@akobrin1
Copy link
Collaborator

  • Fixed Docker API version mismatch by pinning to v25.0.6 (API v1.44+, compatible with interchaintest v8)
  • Fixed 4 reliability bugs in ICA test: silent tx failure parsing, hardcoded ICA channel ID, no retry on ICA address query, unchecked bank send result
  • Simplified Dockerfile after crisis module removal in Lumera v1.10.1 (removed entrypoint script, kept flag-stripping wrapper)
  • Removed v1.9.1 version-specific code paths (single genesis modifier, no more ChainVersion enum)
  • Updated buildpacket tool for sdk-go v1.0.9 (NewMultiChainKeyring → NewKeyring + KeyTypeCosmos)
  • Added GitHub Actions CI workflow with reusable setup-go composite action

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves the reliability and simplicity of the Lumera interchaintest suite through bug fixes, version updates, and removal of legacy code paths.

Changes:

  • Fixed Docker API compatibility by pinning to v25.0.6 (API v1.44+)
  • Fixed 4 ICA test reliability bugs: silent tx failure parsing, hardcoded channel ID, missing retry logic, and unchecked bank send
  • Removed v1.9.1-specific code paths and simplified to single genesis modifier
  • Updated buildpacket tool for sdk-go v1.0.9 API changes (NewMultiChainKeyring → NewKeyring)
  • Added GitHub Actions CI workflow with composite setup-go action
  • Updated numerous dependency versions in go.sum/go.mod

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updated Docker pin from v24 to v25, added new indirect dependencies
go.sum Updated many transitive dependencies to newer versions
tools/buildpacket/main.go Updated to use sdk-go v1.0.9 keyring API (NewKeyring + KeyTypeCosmos), added detailed comments
tools/buildpacket/go.mod Updated sdk-go to v1.0.9, cosmos-sdk to v0.53.5, ibc-go to v10.5.0
tools/buildpacket/go.sum Updated dependency checksums for new versions
ica_test.go Fixed tx response parsing, added polling for ICA address, added findICAChannel, improved error handling, cached buildpacket binary compilation
chain_config.go Removed ChainVersion enum and v1.9.1-specific code, simplified to single genesis modifier
genesis_test.go Removed v1.9.1 version checks and TestBothVersions, simplified to test single version
start-lumera-standalone.sh Removed version-specific crisis module removal logic
Dockerfile Removed entrypoint script (crisis module handling now in wrapper only)
Makefile Removed version-specific targets, added LUMERA_VERSION variable
build-docker.sh Updated example command to use generic version placeholder
README.md Removed v1.9.1 documentation, simplified version handling instructions
SETUP_SUMMARY.md Removed v1.9.1 references, simplified documentation
.github/workflows/ica-test.yml Added CI workflow for automated testing
.github/actions/setup-go/action.yml Added reusable composite action to detect Go version from go.mod

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@akobrin1 akobrin1 merged commit 301b915 into master Feb 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments