Conversation
Collaborator
akobrin1
commented
Feb 16, 2026
- Fixed Docker API version mismatch by pinning to v25.0.6 (API v1.44+, compatible with interchaintest v8)
- Fixed 4 reliability bugs in ICA test: silent tx failure parsing, hardcoded ICA channel ID, no retry on ICA address query, unchecked bank send result
- Simplified Dockerfile after crisis module removal in Lumera v1.10.1 (removed entrypoint script, kept flag-stripping wrapper)
- Removed v1.9.1 version-specific code paths (single genesis modifier, no more ChainVersion enum)
- Updated buildpacket tool for sdk-go v1.0.9 (NewMultiChainKeyring → NewKeyring + KeyTypeCosmos)
- Added GitHub Actions CI workflow with reusable setup-go composite action
There was a problem hiding this comment.
Pull request overview
This pull request improves the reliability and simplicity of the Lumera interchaintest suite through bug fixes, version updates, and removal of legacy code paths.
Changes:
- Fixed Docker API compatibility by pinning to v25.0.6 (API v1.44+)
- Fixed 4 ICA test reliability bugs: silent tx failure parsing, hardcoded channel ID, missing retry logic, and unchecked bank send
- Removed v1.9.1-specific code paths and simplified to single genesis modifier
- Updated buildpacket tool for sdk-go v1.0.9 API changes (NewMultiChainKeyring → NewKeyring)
- Added GitHub Actions CI workflow with composite setup-go action
- Updated numerous dependency versions in go.sum/go.mod
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Docker pin from v24 to v25, added new indirect dependencies |
| go.sum | Updated many transitive dependencies to newer versions |
| tools/buildpacket/main.go | Updated to use sdk-go v1.0.9 keyring API (NewKeyring + KeyTypeCosmos), added detailed comments |
| tools/buildpacket/go.mod | Updated sdk-go to v1.0.9, cosmos-sdk to v0.53.5, ibc-go to v10.5.0 |
| tools/buildpacket/go.sum | Updated dependency checksums for new versions |
| ica_test.go | Fixed tx response parsing, added polling for ICA address, added findICAChannel, improved error handling, cached buildpacket binary compilation |
| chain_config.go | Removed ChainVersion enum and v1.9.1-specific code, simplified to single genesis modifier |
| genesis_test.go | Removed v1.9.1 version checks and TestBothVersions, simplified to test single version |
| start-lumera-standalone.sh | Removed version-specific crisis module removal logic |
| Dockerfile | Removed entrypoint script (crisis module handling now in wrapper only) |
| Makefile | Removed version-specific targets, added LUMERA_VERSION variable |
| build-docker.sh | Updated example command to use generic version placeholder |
| README.md | Removed v1.9.1 documentation, simplified version handling instructions |
| SETUP_SUMMARY.md | Removed v1.9.1 references, simplified documentation |
| .github/workflows/ica-test.yml | Added CI workflow for automated testing |
| .github/actions/setup-go/action.yml | Added reusable composite action to detect Go version from go.mod |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.