Added unified keyring support from sdk-go v1.0.9#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds unified keyring support by upgrading to sdk-go v1.0.9 and lumera v1.10.1, introducing configurable key types for both Lumera and controller chains. The changes enable support for "cosmos" (secp256k1) and "evm" (eth_secp256k1) key algorithms, wire the HostKeyName into the ICA controller configuration, and pin the GitHub Actions setup-go version for reproducibility.
Changes:
- Upgraded sdk-go from v1.0.7 to v1.0.9 and lumera from v1.9.1 to v1.10.1, along with numerous transitive dependency updates
- Added key_type configuration fields to both [lumera] and [controller] sections in config.toml with documentation
- Introduced ParseKeyType() exported function and normalizeKeyType() internal function to validate and normalize key type values, with support for "cosmos" and "evm" types
- Wired cfg.Lumera.KeyName as HostKeyName in the ICA controller configuration to enable independent key resolution
- Pinned actions/setup-go to v6.2.0 in CI workflow
- Removed cosmos-sdk replace directive from go.mod
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated sdk-go to v1.0.9, lumera to v1.10.1, cosmos-sdk to v0.53.5, removed cosmos-sdk replace directive, updated numerous transitive dependencies |
| go.sum | Checksum updates for all dependency changes |
| config.toml | Added commented key_type configuration fields to [lumera] and [controller] sections with documentation |
| client/config.go | Added KeyType fields to LumeraConfig and ControllerConfig structs; implemented ParseKeyType() and normalizeKeyType() functions; added validation logic |
| client/ica_controller.go | Added HostKeyName field to ica.Config using cfg.Lumera.KeyName |
| .github/actions/setup-go/action.yml | Pinned actions/setup-go from v6 to v6.2.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details