Skip to content

Added unified keyring support from sdk-go v1.0.9#1

Merged
akobrin1 merged 2 commits intomainfrom
unified-keyring-support
Feb 16, 2026
Merged

Added unified keyring support from sdk-go v1.0.9#1
akobrin1 merged 2 commits intomainfrom
unified-keyring-support

Conversation

@akobrin1
Copy link
Collaborator

Summary

  • Added key_type configuration to both [lumera] and [controller] sections, supporting "cosmos" (secp256k1) and "evm" (eth_secp256k1) key algorithms via the unified keyring introduced in sdk-go v1.0.9
  • Wired HostKeyName into the ICA controller config so controller and host chains can use independent keys from the same keyring
  • Upgraded sdk-go to v1.0.9 and lumera to v1.10.1

Details

  • Introduced ParseKeyType() exported helper that converted config strings to sdkcrypto.KeyType for use with LoadKeyring() and ImportKey()
  • Added validation and normalization of key_type in config loading (defaults to "cosmos" when unset)
  • Passed cfg.Lumera.KeyName as HostKeyName in ica.Config to enable separate host-chain key resolution
  • Updated config.toml with documented key_type entries (commented out, defaulting to cosmos)
  • Pinned actions/setup-go to v6.2.0 in CI

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds unified keyring support by upgrading to sdk-go v1.0.9 and lumera v1.10.1, introducing configurable key types for both Lumera and controller chains. The changes enable support for "cosmos" (secp256k1) and "evm" (eth_secp256k1) key algorithms, wire the HostKeyName into the ICA controller configuration, and pin the GitHub Actions setup-go version for reproducibility.

Changes:

  • Upgraded sdk-go from v1.0.7 to v1.0.9 and lumera from v1.9.1 to v1.10.1, along with numerous transitive dependency updates
  • Added key_type configuration fields to both [lumera] and [controller] sections in config.toml with documentation
  • Introduced ParseKeyType() exported function and normalizeKeyType() internal function to validate and normalize key type values, with support for "cosmos" and "evm" types
  • Wired cfg.Lumera.KeyName as HostKeyName in the ICA controller configuration to enable independent key resolution
  • Pinned actions/setup-go to v6.2.0 in CI workflow
  • Removed cosmos-sdk replace directive from go.mod

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Updated sdk-go to v1.0.9, lumera to v1.10.1, cosmos-sdk to v0.53.5, removed cosmos-sdk replace directive, updated numerous transitive dependencies
go.sum Checksum updates for all dependency changes
config.toml Added commented key_type configuration fields to [lumera] and [controller] sections with documentation
client/config.go Added KeyType fields to LumeraConfig and ControllerConfig structs; implemented ParseKeyType() and normalizeKeyType() functions; added validation logic
client/ica_controller.go Added HostKeyName field to ica.Config using cfg.Lumera.KeyName
.github/actions/setup-go/action.yml Pinned actions/setup-go from v6 to v6.2.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@akobrin1 akobrin1 merged commit 4714bfa into main Feb 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments