fix storage calculation in metrics

[mateeullahmalik]

No description provided.

[roomote]

Rooviewer   See task on Roo Cloud

All issues have been addressed. The PR looks good to merge.

• Add documentation explaining the rationale for the diskTotalAdjustFactor constant (line 55)

Previous reviews

• 3bcc47e: Review #1
• 5eef05d: Review #2
• e6291b9: Review #3

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[Copilot]

Pull request overview

This PR attempts to fix storage calculation in metrics by applying an adjustment factor to the reported disk total size. However, the implementation introduces critical inconsistencies in the metrics calculations.

Key Changes:

• Added math.Floor() and a 1.034 adjustment factor to DiskTotalGb calculation
• Added math package import

Comments suppressed due to low confidence (1)

supernode/supernode_metrics/metrics_collection.go:63

• Fallback calculation uses unadjusted storage.TotalBytes instead of adjusted metrics.DiskTotalGb. When DiskUsagePercent is 0 and needs to be calculated, this fallback divides by storage.TotalBytes (the original unadjusted value) rather than by the adjusted metrics.DiskTotalGb value computed on line 57. This creates an inconsistency where the usage percentage would be calculated against a different total than what's reported in DiskTotalGb, potentially resulting in usage percentages that don't align with the reported total and free GB values.

		if metrics.DiskUsagePercent == 0 && storage.TotalBytes > 0 {
			used := storage.TotalBytes - storage.AvailableBytes
			metrics.DiskUsagePercent = float64(used) / float64(storage.TotalBytes) * 100

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.