Skip to content

Allow cascade downloads for APPROVED actions#261

Merged
akobrin1 merged 1 commit intomasterfrom
download-approved-actions
Jan 15, 2026
Merged

Allow cascade downloads for APPROVED actions#261
akobrin1 merged 1 commit intomasterfrom
download-approved-actions

Conversation

@akobrin1
Copy link
Contributor

This change updates cascade download validation to accept both DONE and APPROVED action states.
It also adds coverage to ensure APPROVED is accepted and invalid states are rejected.
Changes:

  • download.go: accept ActionStateApproved; improve error message.
  • stream_send_error_test.go: add tests for APPROVED and invalid (PENDING) states.

@roomote
Copy link

roomote bot commented Jan 15, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The changes correctly extend cascade download validation to accept both DONE and APPROVED action states. The implementation is clean and the test coverage is appropriate.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@akobrin1 akobrin1 merged commit 38fb84b into master Jan 15, 2026
7 checks passed
@akobrin1 akobrin1 deleted the download-approved-actions branch January 15, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments