Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors event type usage in SDK progress tracking and updates task status handling throughout the codebase. Key changes include:
- Replacement of legacy event type names with new SDK-specific event types in tests, task routines, and event mapping.
- Introduction of a new progress tracking mechanism in the event package with updated status and percentage computations.
- Updates to supernode adapter tests and cache status assignments to align with the new event and progress patterns.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/system/e2e_cascade_test.go | Updated event type checks to use new SDK event types. |
| sdk/task/task.go | Renamed EmitEvent to emitEvent and adjusted LogEvent calls to use sdk events. |
| sdk/task/manager.go | Modified task status updates and switched event types for task life cycle. |
| sdk/task/cascade.go | Updated SDK log events during cascade task execution and registration. |
| sdk/task/cache.go | Consistently uses event package status constants in task cache management. |
| sdk/event/types.go | Replaced old event types with new SDK event types; introduced new supernode events. |
| sdk/event/progress.go | Added comprehensive progress reporting logic with percentage mapping. |
| sdk/adapters/supernodeservice/types_test.go | Adjusted tests to expect new event type mappings for supernode events. |
| sdk/adapters/supernodeservice/adapter.go | Updated event mapping to align with new event names. |
j-rafique
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.