fix: make docs deployment optional and improve artifact download inst… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructions - Add condition to publish-docs job to only run on version tags - This prevents CI from failing when GitHub Pages is not enabled - Expand README installation instructions with detailed artifact download steps - List all available wheel artifacts by platform and architecture - Add note about 90-day artifact expiration Resolves issue where CI appeared to fail but wheels were actually built successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| needs: [test, docs] | ||
|
|
||
| # Only run if GitHub Pages is enabled (on main branch with tag, or manually triggered) | ||
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') |
There was a problem hiding this comment.
Bug: Manual workflow trigger not allowed despite comment
The condition only checks for github.event_name == 'push', which excludes workflow_dispatch events. This contradicts the comment on line 515 stating the job runs when "manually triggered". Manual workflow triggers use github.event_name == 'workflow_dispatch', so the publish-docs job won't run when manually triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ructions
Resolves issue where CI appeared to fail but wheels were actually built successfully.
🤖 Generated with Claude Code
Note
Restricts the
publish-docsworkflow to version tag pushes and expands README with clear GitHub Actions artifact download/installation instructions.publish-docsjob in.github/workflows/ci.ymlto run only onpushevents to version tags (refs/tags/v*).Written by Cursor Bugbot for commit 033bab6. This will update automatically on new commits. Configure here.