Skip to content

fix find reservation with machines under maintenance #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheStrgamer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix find reservation with machines under maintenance #780

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
738744c
machines under maintenance no longer show up when looking for machines
TheStrgamer Oct 30, 2025
478cae7
made statement prettier
TheStrgamer Nov 6, 2025
5a0abce
Merge branch 'main' into fix-find-reservation-when-machines-under-mai…
TheStrgamer Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/make_queue/views/reservation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,8 +415,12 @@ def form_valid(self, form):

periods = []
for machine in form.cleaned_data["machine_type"].machines.all():
if not machine.get_status() == Machine.Status.OUT_OF_ORDER:
periods.extend(self.get_periods(machine, required_time))
if machine.get_status() in (
Machine.Status.OUT_OF_ORDER,
Machine.Status.MAINTENANCE,
):
continue
periods.extend(self.get_periods(machine, required_time))

# Periods in the near future is more interesting than in the distant
# future
Expand Down