Made number of tickets be set to 0 when event is set to repeating#798
Open
SnorreForbregd wants to merge 2 commits intomainfrom
Open
Made number of tickets be set to 0 when event is set to repeating#798SnorreForbregd wants to merge 2 commits intomainfrom
SnorreForbregd wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 153 153
Lines 6225 6225
=======================================
Hits 5479 5479
Misses 746 746 🚀 New features to boost your workflow:
|
ddabble
reviewed
Mar 12, 2026
Comment on lines
+15
to
+16
| - Made it so when creating an event, the amount of tickets is set to 0 when setting the event to repeating | ||
| - https://github.com/MAKENTNU/web/pull/798 |
Member
There was a problem hiding this comment.
Nice to use the same format as the other entries below :)
Also looks like a leading space was missing for the second line. A protip is to check how the markdown code renders by editing any of our .md files directly on GitHub (e.g. the changelog), and pressing the "Preview" tab/button at the top - without committing the changes (unless you want, of course :))
Suggested change
| - Made it so when creating an event, the amount of tickets is set to 0 when setting the event to repeating | |
| - https://github.com/MAKENTNU/web/pull/798 | |
| - Made it so when creating an event, the amount of tickets is set to 0 when setting the event to repeating | |
| (MAKENTNU/web#798) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When creating an event, if the
amount-of-ticketsfield was set to a number before changing the event type to repeating, the event page would list 0/x tickets, even though there was no way to sign up.This change makes it so the number is set to 0 when the event type is set to repeating.
This closes #795
Review guidance
All that was changed was the addition of the line
$("#id_number_of_tickets").prop("value", 0);in web/src/news/static/news/js/event/event_form.jsChecklist
(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)
makemigrations,makemessagesandcompilemessages