Skip to content

Management command tests#807

Open
ddabble wants to merge 4 commits intosimpler-po-filesfrom
management-command-tests
Open

Management command tests#807
ddabble wants to merge 4 commits intosimpler-po-filesfrom
management-command-tests

Conversation

@ddabble
Copy link
Member

@ddabble ddabble commented Mar 24, 2026

Depends on #806.

Proposed changes

Added some management command tests (62d75bb). This removes the need for the following checklist item in pull_request_template.md:

  • I've run makemigrations, makemessages and compilemessages

Also:

  • Added missing migration changes (5ea3b2c)
  • Upgraded django-decorator-include (9124f7e)

Review guidance

Checklist

(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)

  • I've written tests that fail without these changes (if relevant/possible)
  • I've manually tested the website UI with different device layouts
    • Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools
  • I've manually tested with different users locally
    • This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers
  • I've made sure that my code conforms to the code style guides
    • It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request
  • I've attempted to minimize the number of common code smells
    • See the comment for the previous checkbox
  • I've added documentation
    • E.g. comments, docstrings, or in the README
  • I've added my changes to the "Unreleased" section of the changelog, together with a link to this PR
    • Mainly the changes that are of particular interest to users and/or developers, if any
  • I've added a "Deployment notes" section above and labelled the PR with has-deployment-notes
    • ...if anything out of the ordinary should be done when deploying these changes to the server (e.g. adding/removing an environment variable, manually creating/changing some objects, running a management command, etc.)
  • I've structured my commits reasonably

ddabble added 3 commits March 24, 2026 23:42
The changes originated in the following commits:
* `checkin/0004_auto_20180906_1855.py`: b57c22a
* `make_queue/0007_auto_20180914_1306.py`: b57c22a
* `make_queue/0036_alter_coursepermission_short_name_and_more.py`: a744023
* `news/0022_abstract_newsbase.py`: b57c22a
This also fixes the following warning:
`UserWarning: pkg_resources is deprecated as an API.`
This removes the need for the following checklist item in
`pull_request_template.md`:
"- [ ] I've run `makemigrations`, `makemessages` and `compilemessages`"
@ddabble ddabble added the ⚡Quick review⚡ This PR is short and can be reviewed quickly. label Mar 24, 2026
@make-bot make-bot bot added this to web Mar 24, 2026
@make-bot make-bot bot moved this to Ready for Review in web Mar 24, 2026
@ddabble ddabble requested a review from TheStrgamer March 24, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚡Quick review⚡ This PR is short and can be reviewed quickly.

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

1 participant