Add JInput check for mouse devices with too many buttons#5
Open
cassandra288 wants to merge 4 commits intoMARYT-Studio:mainfrom
Open
Add JInput check for mouse devices with too many buttons#5cassandra288 wants to merge 4 commits intoMARYT-Studio:mainfrom
cassandra288 wants to merge 4 commits intoMARYT-Studio:mainfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been having issues with using raw mouse input and, with some digging, I discovered the problem stems from JInput. For some reason it's picking up a device on my system with 32 buttons:
Which then proceeded to cause this error:
We can see here in JInput 2.0.5 (the version older minecraft versioned like 1.12.2 used) that it iterates through the buttons to set them up but it can't handle devices with >= 32 buttons.
This PR adds an ASM transformer to inject a safety check into that method, to reject devices with >= 32 buttons (similar to how it already rejects when = 0 buttons).
I believe others may have been having this issue too:
xCuri0#11