feat: add MIMIC-IV OMOP test support (closes #13)#24
Merged
tompollard merged 1 commit intomainfrom Nov 23, 2025
Merged
Conversation
Member
|
Very cool, thanks @rafiattrach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add MIMIC-IV OMOP test support and validation
This PR adds the MIMIC-IV OMOP demo dataset to the test suite and verifies that
croissant-makercorrectly generates metadata for it "out of the box".Changes
tests/data/input/.test_mimiciv_demo_omop_generationintests/test_end_to_end.py.Results
The existing
CSVHandlersuccessfully processed all 22 CSV files in the OMOP export without requiring any code changes.provider.csv,note.csv) to avoid creating empty RecordSets.Related
Closes #13