Update MultiHeaderMixin header formatting to match HeaderMixin formatting
#544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the duplicated preprocessing for the header fields to a standalone function for sustainability. |
briangow
force-pushed
the
bg_multiheader
branch
from
059d9a8 to
e355422
Compare
|
See #548 regarding the new test error. |
|
Not tested but it makes sense to me. Thanks!
The logic for reformatting date strings looks fragile and I wonder if there's a reason it's not just using strftime("%d/%m/%Y"). But that's another issue.
|
|
@bemoody , I agree that the old approach of formatting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 63c987f updates to
HeaderMixinwere made to properly format the header date and time fields. This fix did not make it intoMultiHeaderMixin(for multi-segment records). Therefore, writing a date using thewrheadermethod underMultiHeaderMixincurrently results in writing thebase_dateas YYYY-MM-DD which isn't compatible with the DD/MM/YYYY format requirement.This PR updated
MultiHeaderMixinby using the code fromHeaderMixinto properly set formats.