Skip to content

Add CODEOWNERS and update dependencies #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghukill merged 2 commits into from
Feb 5, 2026
Merged

Add CODEOWNERS and update dependencies #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad745a
Add CODEOWNERS and update dependencies
ghukill Feb 3, 2026
88dc80d
Update CODEOWNERS with InfraEng for GHA workflows
ghukill Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# CODEOWNERS file (from GitHub template at
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners)
# Each line is a file pattern followed by one or more owners.

################################################################################
# These owners will be the default owners for everything in the repo. This is commented
# out in favor of using a team as the default (see below). It is left here as a comment
# to indicate the primary expert for this code.
# * @ghukill

# Teams can be specified as code owners as well. Teams should be identified in
Copy link
Contributor

@cabutlermit cabutlermit Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghukill It might be worth adding a line specifying that the workflows should be linked to InfraEng..

Copy link
Collaborator Author

@ghukill ghukill Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabutlermit - Happy to add, but do you think it's more true for this repository than others? does adding it here imply we should be adding InfraEng globally to CODEOWNERS files?

Copy link
Contributor

@cabutlermit cabutlermit Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I should have been more specific and more detailed in my comment. I'm picturing lines like this in CODEOWNERS, at least in this repo and maybe in other repos that have GHA workflows that publish apps to ECR in AWS.

/.github/dev-* @mitlibraries/infraeng
/.github/stage-* @mitlibraries/infraeng
/.github/prod-* @mitlibraries/infraeng

Or, maybe this would do it (I think that later lines override earlier lines):

/.github/* @mitlibraries/infraeng
/.github/ci.yml @mitlibraries/dataeng

That way, if anyone ever makes changes to those workflow files and PR's those changes, InfraEng will automatically get tagged for review.

Copy link
Collaborator Author

@ghukill ghukill Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabutlermit - Ahhhhh! Makes sense, love it. Thanks for the clarification. I don't have very strong CODEOWNERS intuition yet, but appreciating this per-file-pattern approach and the implications there. Will add.

Copy link
Collaborator Author

@ghukill ghukill Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit here: 88dc80d. Review re-requested.

# the format @org/team-name. Teams must have explicit write access to the
# repository.
* @mitlibraries/dataeng
/.github/* @mitlibraries/infraeng
/.github/ci.yml @mitlibraries/dataeng

# We set the senior engineer in the team as the owner of the CODEOWNERS file as
# a layer of protection for unauthorized changes.
/.github/CODEOWNERS @ghukill
Loading