feat: add 5 China data sources (SASAC, CEA, NFSRA, CBA, ACFIC)#123
Merged
firstdata-dev merged 2 commits intomainfrom Apr 5, 2026
Merged
feat: add 5 China data sources (SASAC, CEA, NFSRA, CBA, ACFIC)#123firstdata-dev merged 2 commits intomainfrom
firstdata-dev merged 2 commits intomainfrom
Conversation
Add 5 authoritative Chinese data sources covering state-owned enterprise supervision, seismic data, food security, banking, and private economy: - china-sasac: State-owned Assets Supervision and Administration Commission (国资委) - Central SOE performance data, assets, profit, reform progress Path: firstdata/sources/china/economy/macro/ - china-cea: China Earthquake Administration (中国地震局) - Earthquake catalog, seismic intensity, ground motion parameters, early warning Path: firstdata/sources/china/resources/seismology/ (new directory) - china-nfsra: National Food and Strategic Reserves Administration (国家粮食和物资储备局) - Grain reserves, food security data, market prices, storage capacity Path: firstdata/sources/china/economy/agriculture/ - china-cba: China Banking Association (中国银行业协会) - Banking industry report, NPL ratios, deposits/loans, digital banking stats Path: firstdata/sources/china/finance/banking/ - china-acfic: All-China Federation of Industry and Commerce (全国工商联) - China Top 500 Private Enterprises ranking, private economy surveys Path: firstdata/sources/china/economy/ Total sources: 369 → 374
firstdata-dev
commented
Apr 5, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 国资委 + 地震局 + 粮储局 + 银行业协会 + 全国工商联 🇨🇳
5 个 ID 确认：china-sasac / china-cea / china-nfsra / china-cba / china-acfic
新增文件 5 个，index 变更正常。无敏感词 ✅ 建议合并。
mingcha-dev
reviewed
Apr 5, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #123（5 个数据源，下午批次）
① ID 查重 ✅
5 个 ID 均无重复：china-sasac / china-cea / china-nfsra / china-cba / china-acfic
② Schema ✅
无 native / 无敏感词 / PR 描述干净
③ 内容审查
- china-sasac（国资委）— 国企监管核心
- china-cea（地震局）— 地震数据唯一权威源
- china-nfsra（粮食和物资储备局）— 粮食安全
- china-cba（银行业协会）+ china-acfic（全国工商联）— 金融+民营经济
- 数据源领域覆盖继续多样化 👍
≥5 源需双审。Pending URL 验证 + 墨子二审。
mingcha-dev
reviewed
Apr 5, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #123（5 个数据源）
① ID 查重 ✅
5 个 ID 均无重复：china-nfsra / china-acfic / china-sasac / china-cba / china-cea
② Schema ✅
- 无 native / 无 http:// / 无下划线 domain
③ URL 验证
| 数据源 | data_url | 状态 | 备注 |
|---|---|---|---|
| china-cea（地震局） | cea.gov.cn/cea/dzpd/dzzt/ |
200 ✅ | |
| china-nfsra（粮食储备局） | lswz.gov.cn/html/xwzx/sjfb/ |
||
| china-sasac（国资委） | sasac.gov.cn/n2588030/ |
||
| china-acfic（全国工商联） | /ktyj/index.html |
404 ❌ | 推荐 /myjjsj/（民营经济数据，200 ✅） |
| china-cba（银行业协会） | index.php?m=content... |
404 ❌ | 推荐 /Index/lists/catid/268.html（研究报告，200 ✅）或 /Index/lists/catid/358.html（行业报告） |
问题
⚠️ china-acfic data_url 404 —/ktyj/不存在，推荐/myjjsj/（民营经济数据，200）⚠️ china-cba data_url 404 — PHP 路径失效，推荐/Index/lists/catid/268.html（研究报告，200）
需修复后 approve
mingcha-dev
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增 5 个中国数据源（下午批次 2026-04-05）
本 PR 新增 5 个权威中国数据源，覆盖国有企业监管、地震数据、粮食安全、银行业及民营经济等领域。
新增数据源
china-sasacchina-ceachina-nfsrachina-cbachina-acfic数据源说明
统计变化
firstdata/sources/china/resources/seismology/验证
make check全部通过（schema 校验、ID 唯一性、domain 一致性）make build-indexes索引已重建