Merged
Conversation
Member
Zpiboo
commented
Mar 20, 2026
Zpiboo
commented
- Fix JSON serialization
- Fix Mark timing not showing if you ran 1t and disallowing WDWA
- Add class parameter to Serializer::serialize and Serializer::serializeAsString - Use Component[] as an intermediate in LabelConfiguration for proper (de)serialization
Exterminate5573
approved these changes
Mar 21, 2026
Zpiboo
added a commit
to Zpiboo/MPKMod2
that referenced
this pull request
Mar 27, 2026
* chore: fix typo in some strats.json ms strings * feat(api): update Range class - Enforce bounds order in the constructor - Rename isAbove method to isValueAbove - Create isValueBelow method - Add equals method * feat(api): provide Tuple with equals method * refactor: move TickInput class to new util.input package * chore(test): add junit dependency * refactor(json): replace global jackson typing to single @JsonTypeInfo annotation above Component * feat(input): introduce new InputVector class * feat(input): create InputPredicate classes These new classes aim to replace one of the current two responsibilities of TimingInput: it can represent both actual player input and a theoretical input predicate. The next commit fixes this by making it only an actual input model. * refactor(input): restrict TimingInput to represent concrete input This tightens TimingInput's responsibility, which used to also be used for input predicates. The latter are now represented using the new InputPredicate* classes. * feat(timing): make TimingEntry json-deserializable and mirrorable * feat(timing): make Timing json-deserializable * feat(timing): make timings mirrorable through "symmetrical" boolean * feat(timing): use new strategy format in strats.json * docs(timing): clarify intent of helper methods used by TimingInput::findMSButtons * tests(timing): create unit tests for timing-related classes (cherry picked from commit b11a863) Better timings fixes (MPKMod#56) * fix(timing): fix mark timing not showing if you ran 1 tick and disallowing WDWA * fix(json): add class parameter to serialize methods - Add class parameter to Serializer::serialize and Serializer::serializeAsString - Use Component[] as an intermediate in LabelConfiguration for proper (de)serialization (cherry picked from commit addba48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.