Skip to content

Fix mirrored timings delay #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Exterminate5573 merged 2 commits into from
Apr 7, 2026
+8 −8
Merged

Fix mirrored timings delay #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36c205c
fix(timing): fix mirrored timings not working while their base form i…
Zpiboo Apr 4, 2026
8a68182
fix(timing): remove useless stop tick conditions
Zpiboo Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion common/src/main/java/io/github/kurrycat/mpkmod/ticks/Timing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ public Match match(List<TimingInput> inputList) {
Match result = null;
for (int i = 0; i < inputList.size() - 1; i++) {
if (inputList.get(i).isStopTick() && !inputList.get(i + 1).isStopTick()) {
Match match = startsWithMatch(inputList.subList(i + 1, inputList.size()));
List<TimingInput> inputSubList = inputList.subList(i + 1, inputList.size());
Match match = startsWithMatch(inputSubList);

if (match == null && isSymmetrical())
match = getMirrored().startsWithMatch(inputSubList);

if (match != null)
result = match;
}
Expand Down
2 changes: 1 addition & 1 deletion common/src/main/java/io/github/kurrycat/mpkmod/ticks/TimingInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ private static int findFirstButtonDiff(boolean[] curInputs, boolean[] aftInputs)
}

public boolean isStopTick() {
return inputVector.isStop() && !P && !N && G == GroundState.GROUNDED;
return inputVector.isStop() && G == GroundState.GROUNDED;
}

@Override
Expand Down
7 changes: 1 addition & 6 deletions common/src/main/java/io/github/kurrycat/mpkmod/ticks/TimingStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,8 @@ public static String match(List<TimingInput> inputList) {
List<Timing.Match> matches = new ArrayList<>();
for (Map.Entry<String, Timing> entry : patterns.entrySet()) {
Timing.Match match = entry.getValue().match(inputList);

if (match == null && entry.getValue().isSymmetrical()) {
match = entry.getValue().getMirrored().match(inputList);
}
if (match != null) {
if (match != null)
matches.add(match);
}
}

if (matches.isEmpty())
Expand Down
Loading