Add background image support with modding fallback and UI toggle #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 68.77% 67.05% -1.73%
==========================================
Files 84 85 +1
Lines 4029 4107 +78
Branches 249 249
==========================================
- Hits 2771 2754 -17
- Misses 1258 1353 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nschimme
force-pushed
the
master
branch
2 times, most recently
from
3e39f0d to
a659e00
Compare
Sunnyl75
force-pushed
the
background-overlay-layer
branch
from
a4c60ba to
0658d19
Compare
nschimme
force-pushed
the
master
branch
3 times, most recently
from
e446b42 to
0f05563
Compare
…xing depth layering issue
- Removed manual QImage loading and texture setup for background image in MapCanvas::initializeGL(). - Background image is now loaded via loadTexture() in initTextures(), using the same fallback mechanism as other modding assets. - Renamed 'background.png' to 'background-image.png' for consistency and alignment with naming in mmapper2.qrc.
- Manually assigned OpenGL texture ID to backgroundImage in initTextures(). - Registered the texture with OpenGL via setTextureLookup(), as done for other manual textures. - Resolves assertion failure in getId() when background image was enabled.
Sunnyl75
force-pushed
the
background-overlay-layer
branch
from
0658d19 to
a8a5adf
Compare
nschimme
force-pushed
the
master
branch
4 times, most recently
from
da9f53b to
2050361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for an optional background image on the map canvas.
Features:
Technical Notes:
background-image.pngAdditional Info:
showBackgroundImagesetting to configbackgroundImageCheckBoxto the UIConsiderations/Limitations:
-Stretches the image between pre-defined room co-ordinates in order to match the background map I cropped.
-These are arbitrary for my uses with the map I made, but could be given an 'official' range if you think it's useful generally.
-The image I supplied isn't necessary - could be a transparent background-image.png in Pixmaps. Then it only loads if in modding folder and toggled.
Tested on macOS with both default and custom background images.
Let me know if any adjustments are needed!