Skip to content

Conversation

@nschimme
Copy link
Contributor

@nschimme nschimme commented Oct 30, 2025

This fixes corrupted user maps with a "River Lh\x00n" room name.

Summary by Sourcery

Map ASCII control characters including NUL to the default unmapped character ('?') during sanitization and charset insertion.

Bug Fixes:

  • Sanitizer now replaces NUL (and other control characters) with '?' in one-line, multiline, and word-wrapped output
  • BasicCharsetInserter now maps ASCII control code points to the default unmapped character instead of passing them through

Tests:

  • Add test_nul to verify NUL is replaced with '?' in sanitizeOneLine, sanitizeMultiline, and sanitizeWordWrapped

This fixes corrupted user maps with a "River Lh\x00n" room name.
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 30, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider adding tests for other control characters (e.g., BEL, DEL) to ensure they are consistently replaced with '?'.
  • Extract the control-character check and replacement logic in BasicCharsetInserter into a small helper function to improve readability and maintainability.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding tests for other control characters (e.g., BEL, DEL) to ensure they are consistently replaced with '?'.
- Extract the control-character check and replacement logic in BasicCharsetInserter into a small helper function to improve readability and maintainability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant