feat: add images to all posts#269
feat: add images to all posts#269fabricioalvarenga wants to merge 6 commits intoMacMagazine:release/v5from
Conversation
Merge release/v5 into feature/add-images-to-posts
|
@cassio-rossi tomei a liberdade de excluir os arquivos SimpleCardView.swift e LeadingCardView.swift. Como os códigos desses dois arquivos eram muito parecidos, criei o arquivo CardView.swift englobando os dois arquivos. Caso prefira manter um arquivo separado para cada tipo de carregamento de imagem (à esquerda, no topo, etc), basta recusar o pull request. |
|
@fabricioalvarenga obrigado. nós ainda estamos trabalhando no layout desses cartões. Vou deixar a PR aberta, mas iremos ter layout diferente por categoria. Semana que vem retomarei os trabalhos nesse assunto. Aguarde novidades. Obrigado de qq maneira. |
|
E também tenho que atualizar a branch |
Description
Images were added to various types of posts (latest news, rumors, highlights, etc.). However, I couldn't figure out how to place the image above the title for videos (they ended up next to the article title).
Type of Change
feat: New featurefix: Bug fixdocs: Documentation updatestyle: Code style/formatting changesrefactor: Code refactoringperf: Performance improvementtest: Adding or updating testschore: Maintenance tasksbuild: Build system changesci: CI configuration changesRelated Issue
Screenshots/Videos
Testing
Checklist
Additional Notes
One detail: it's still necessary to remove the line limit for titles in some cases to prevent them from being "cut off" and ending with "...".