Move into an async function to allow await on writeJson#53
Open
jocull wants to merge 1 commit intoMalexion:masterfrom
Open
Move into an async function to allow await on writeJson#53jocull wants to merge 1 commit intoMalexion:masterfrom
await on writeJson#53jocull wants to merge 1 commit intoMalexion:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For new installations,
writeJsonhappens async, so the file does not exist by the timerequireis called, crashing the app without the template being created.This moves the main block into an async function so we can
awaitthe write before moving on 😄