Convert PatternFly icons to Carbon #9649
Conversation
kbrock
force-pushed
the
update_icons_gtl
branch
from
e272983 to
90dddba
Compare
Co-authored-by: Gilbert Cherrie <Gilbert.Cherrie@ibm.com> Co-authored-by: Keenan Brock <keenan@thebrocks.net>
kbrock
force-pushed
the
update_icons_gtl
branch
from
90dddba to
a17c36c
Compare
kbrock
changed the title
|
I'm testing this locally to verify the sporadic failures are unrelated to this issue. |
|
I ran this locally a few times and it was a sporadic failure that should be addressed in some of the recent changes. |
| 'on' => 'carbon--Power', | ||
| 'never' => 'carbon--Power', | ||
| 'terminated' => 'carbon--Power', | ||
| 'off' => 'carbon--Power', |
There was a problem hiding this comment.
@elsamaryv can you review this? before on/off had different icons and now it's the same one.
| 'off' => 'carbon--Power', | ||
| 'template' => 'carbon--Template', | ||
| 'powering_up' => 'carbon--Power', | ||
| 'powering_down' => 'carbon--Power', |
There was a problem hiding this comment.
Similar to above... do we have a screen with both powering up and down to see what it looks like before/after? I feel like they might need to be different.
There was a problem hiding this comment.
Agreed - I'd like to see a screenshot of each of these, if possible.
There was a problem hiding this comment.
so https://www.ibm.com/design/language/iconography/ui-icons/library/ search "power" was pretty sparse. But I looked up plug and off and a few others.
Here is what I found:
There was a problem hiding this comment.
Oh sorry I meant in the context of the app. Like Power might make sense if on is green and off is red, but hard to tell without seeing it.
There was a problem hiding this comment.
I am testing them. Will share the screenshots
| 'shelved' => 'carbon--Hourglass', | ||
| 'shelved_offloaded' => 'carbon--Hourglass', | ||
| 'reboot_in_progress' => 'carbon--Power', | ||
| 'wait_for_launch' => 'carbon--asleep', |
There was a problem hiding this comment.
looking at https://carbondesignsystem.com/elements/icons/library/. I wonder if "InProgress" could be used for the wait/in progress
| 'non_operational' => 'carbon--WarningSquare', | ||
| 'suspended' => 'carbon--asleep', | ||
| 'standby' => 'carbon--asleep', | ||
| 'paused' => 'carbon--asleep', |
There was a problem hiding this comment.
there is a pause, not sure if we want to change what was also asleep previously.
|
@Fryguy cc, please take a look... I think this is ready to go but had a few comments above |
|
The icons look a bit too big, but maybe that's normal for carbon? If not, maybe we need some CSS cleanup there. |
|
I have done some updates and screenshots are added here. Icon size also reduced |
|
Closed by #9721 |
5 participants
This converts pattern fly icons to carbon icons.
All icons have been tested, but the new ones seem to be taller
Before
After