Conversation
| self.parametric_function: Callable[[float], Point3D] = lambda t: np.array( | ||
| [t, function(t), 0] | ||
| ) | ||
| self.function = function # type: ignore[assignment] |
There was a problem hiding this comment.
Don't know how to resolve this.
| f"Expected a float type result, got {type(result)}." | ||
| ) | ||
| return result | ||
| return np.log(value) / np.log(base) # type: ignore [no-any-return] |
There was a problem hiding this comment.
Not sure how to resolve this type hint error.
| def function(self, value: float) -> float: | ||
| """Scales the value to fit it to a logarithmic scale.``self.function(5)==10**5``""" | ||
| return float(self.base**value) | ||
| return self.base**value # type: ignore [no-any-return] |
There was a problem hiding this comment.
Don't know yet how to resolve this.
Check for value errors in function() and inverse function()
|
Nice to see more typing work! I have also added type annotations for the graphing/scale.py in #4125, but it seems like you have also updated some warnings in the code that I haven't dealt with. Regarding the |
fmuenkel
force-pushed
the
typing-mobject-graphing
branch
from
18f104b to
6af8ac1
Compare
|
Superseded by #4125. |
|
@fmuenkel Sorry for intervening with your work in this pull request. |
|
@henrikmidtiby No worries, a lot of it was error handling, which should be in a separate PR anyhow. |
2 participants
Overview: What does this pull request change?
Related to #3375.
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist