Skip to content

Fixed NumberLine get_number_mobjects() and get_labels() #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BillyLjm wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

Fixed NumberLine get_number_mobjects() and get_labels() #4638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bd16d
fixed NumberLine.get_number_mobject()
BillyLjm Mar 14, 2026
a58d097
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manim/mobject/graphing/number_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,11 +504,11 @@ def get_number_mobject(

def get_number_mobjects(self, *numbers: float, **kwargs: Any) -> VGroup:
if len(numbers) == 0:
numbers = self.default_numbers_to_display()
numbers = self.get_tick_range()
return VGroup([self.get_number_mobject(number, **kwargs) for number in numbers])

def get_labels(self) -> VGroup:
return self.get_number_mobjects()
return getattr(self, "labels", self.get_number_mobjects())

def add_numbers(
self,
Expand Down
11 changes: 10 additions & 1 deletion tests/module/mobject/graphing/test_number_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np

from manim import DashedLine, NumberLine
from manim.mobject.text.numbers import Integer
from manim.mobject.text.numbers import DecimalNumber, Integer


def test_unit_vector():
Expand Down Expand Up @@ -70,6 +70,15 @@ def test_add_labels():
)


def test_get_number_mobjects():
num_line = NumberLine(x_range=[-4, 4])
mobjects = num_line.get_number_mobjects()
for mobject in mobjects:
assert isinstance(mobject, DecimalNumber), (
f"Expected a VGroup of DecimalNumber but got {type(mobject)}"
)


def test_number_to_point():
line = NumberLine()
numbers = [1, 2, 3, 4, 5]
Expand Down
Loading