Pass the correct callback to dispatchMail#65
Open
smurthas wants to merge 1 commit intoMarak:masterfrom
Open
Conversation
… message itself, and call that once it can been sent.
Author
|
Do you think you'll be able to pull this in anytime soon? We've been pointing to my fork in our package.json for a while now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If several messages got queued up during the
fs.readFilecall for a single template, when the template was finally loaded,dispatchMailwould get called for each message, but would get passed the callback associated with the first one (the only one that invoked thefs.readFilecall). This bundles the callback in with the message itself, ensuring that the callback associated with that message is the one passed todispatchMail