Skip to content

Conversation

@alan67160
Copy link
Contributor

allow PluginUtils.fromString() accept loc without yaw and pitch

allow PluginUtils.fromString() accept loc without yaw and pitch
@MartenM
Copy link
Owner

MartenM commented Sep 27, 2023

Wouldn't this effectively set the location to yaw and pitch 0 0?

@alan67160
Copy link
Contributor Author

sorry that was a mistake. I'm trying to keep the viewing angle, so I think removing the pitch and yaw will do it, but the truth is not.
so maybe changing the following line will do the work?
src/main/java/nl/martenm/servertutorialplus/points/ServerTutorialPoint.java#L103
by adding a check on that line
if pitch and yaw no provided in the config file then clone the player pitch and yaw to target location?

@MartenM
Copy link
Owner

MartenM commented Sep 27, 2023

Creating an argument for points that teleport which could be (keepYawPitch) could be a thing.
Although to be honest, teleporting to a spot and not resetting the yaw and pitch might confuse players.

@alan67160
Copy link
Contributor Author

alan67160 commented Sep 28, 2023

let me give you a reasonable example
checkpoint will teleport player after player arrived the checkpoint
I am using checkpoint to create a path guidance and sending a message to you in every checkpoint to look like on talking to you right by your side
in that case the player constantly change the view

@MartenM
Copy link
Owner

MartenM commented Sep 28, 2023

let me give you a reasonable example checkpoint will teleport player after player arrived the checkpoint I am using checkpoint to create a path guidance and sending a message to you in every checkpoint to look like on talking to you right by your side in that case the player constantly change the view

Wouldn't disabling the teleport on the checkpoint make more sense? That's already possible.

@alan67160
Copy link
Contributor Author

I have already tried it to disable the teleport but it still teleport

tutorials:
  t1:
    stats:
      plays: 13
    invisible: false
    permission: false
    block-chat: false
    blocks-commands: false
    rewards: []
    command-whitelist: []
    points:
      '6':
        type: CHECKPOINT
        location: plot 37.5 97.5 2.5 1.91 -5.11
        time: 0.5
        locplayer: false
        locview: false
        teleport: false
        messages: []
        commands:
        - custom_events_delaymsg 0.5 %player_name% <&a教學喵蟲&f> GoGo!!
        animation: CIRCLE
        colour: 244 153 0
        distance: 1.0
        repeatActionbar: true
        drawguide: true
        guidecolour: 244 244 244

(0 to 5 was removed as it doesn't related)

@alan67160
Copy link
Contributor Author

alan67160 commented Sep 28, 2023

on github I only see the teleport argument loaded for ClickBlockPoint

ClickBlockPoint.java
src/main/java/nl/martenm/servertutorialplus/points/custom/ClickBlockPoint.java#L129

CheckPoint.java
src/main/java/nl/martenm/servertutorialplus/points/custom/CheckPoint.java#L171

@MartenM
Copy link
Owner

MartenM commented Sep 28, 2023

You should try to edit these things in-game using the commands. It will tell you if something is available or not.
If what you said is true, a PR that enables this for the checkpoint would be better :)

@alan67160 alan67160 closed this Sep 29, 2023
@alan67160 alan67160 deleted the patch-1 branch September 29, 2023 04:33
@alan67160 alan67160 changed the title Update PluginUtils.java add teleport option support to checkpoint Sep 29, 2023
@alan67160
Copy link
Contributor Author

moved to #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants