Skip to content

Conversation

@Fameless9
Copy link
Contributor

@Fameless9 Fameless9 commented Apr 21, 2024

Hi, this PR adds a hide-after and show-after option to the actionbar. The runnable controlling when to show and hide the actionbar automatically cancels when the point has finished or the hide-after has been reached, so it will not lead to any overload on the server.

Example:

Configuration:

actionbar:
  message: '&4Text'
  show-after: 2.5
  hide-after: 3.5
ServerTutorialPlus.actionbar.mp4
  • by default, the text will stay on screen until the point has finished
  • to hide the text when needed, an empty actionbar message will be sent
  • show-after and hide-after should both be specified in seconds

Copy link
Owner

@MartenM MartenM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fair enough. I do remember the actionbar having an option to 'repeat' though. How does it interact with that functionality?

Also I am not seeing a command that allow for editing this variable. Please attach an editor that allows for this for the corresponding points. Check how this is done for the other points.

protected List<FireWorkInfo> fireworks;
protected String message_actionBar;
protected double actionbar_show_after;
protected double actionbar_hide_after;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the java naming conventions (even though I messed up the message_actionBar variable).
So actionbarShowAfter and actionbarHideAfter.

@Fameless9
Copy link
Contributor Author

Fameless9 commented Apr 22, 2024

Hi, the changes won't interfere with the repeatActionbar, however, the actionbar will never be hidden when repeatActionbar is true.

@Fameless9 Fameless9 requested a review from MartenM May 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants