-
Notifications
You must be signed in to change notification settings - Fork 17
Added bossbar feature #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Seems to be quite an okay PR. |
MartenM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but seems to be missing an editor that allows to change this in-game.
Please attach one. See other settings for how this is done.
| try { | ||
| String bossBarStyleString = tutorialSaves.getString("tutorials." + ID + ".points." + i + ".bossbar.style", "SOLID"); | ||
| bossBarStyle = BarStyle.valueOf(bossBarStyleString.toUpperCase()); | ||
| } catch (IllegalArgumentException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for the 'try-catch' blocks here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the exception IllegalArgumentException is caught when the valueOf method is called on the BarStyle enum with a string that doesn't match any of the enum constants.
|
latest commit added the editor command /st editpoint bossbar <title/progress/color/style/show-after/hide-after> |
|
Any progress as I'm personally interested in this feature, but already thanks for your work guys! |
|
I'm quite busy with my personal life right now. |
Hello, this PR adds a bossbar option.
Options
the bossbar feature supports the following options:
The runnable controlling when to hide and show the bossbar will also automatically cancel itself when either the point has finished or
hide-afterhas been reached to save resources.Default values
title: empty, bossbar will not be shown
progress: 1.0
color: WHITE
style: SOLID
show-after: 0.0
hide-after: duration of the point
Example
ServerTutorialPlus.bossbar.mp4