[1.x] backport string reading enhancements#323
Merged
mbunkus merged 2 commits intoMatroska-Org:v1.xfrom Aug 5, 2025
Merged
Conversation
ePirat
pushed a commit
to videolan/vlc
that referenced
this pull request
Jul 29, 2025
The code is cleaner and doesn't leak local buffers when readFully() emits an exception. As in "oss-fuzz 5479158623043584". Backport sent upstream at Matroska-Org/libebml#323
ePirat
pushed a commit
to videolan/vlc
that referenced
this pull request
Jul 30, 2025
The code is cleaner and doesn't leak local buffers when readFully() emits an exception. As in "oss-fuzz 5479158623043584". Backport sent upstream at Matroska-Org/libebml#323 (cherry picked from commit bee5a09)
mbunkus
approved these changes
Aug 5, 2025
Contributor
mbunkus
left a comment
mbunkus
left a comment
There was a problem hiding this comment.
This makes a lot of sense & works just fine with MKVToolNix' test suite. I'll merge in a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids some leaks when readFully() emits an exception.