Conversation
|
@MaxWinterstein any question or concerns with this? |
|
Python 3.8 has already reached its end-of-life anyway, so I don't see any point in supporting python 3.8. |
|
I suppose that's fair, although unfortunately upgrading is not that quick of a process for us 😅. I think if the package supports 3.8 in reality, there's no reason to incorrectly mark it as not supporting 3.8 just because it's EOL |
Assume your org has a private artifact platform. If upgrading to >= python3.9 is an issue, you can probably just fork this repo and apply your code changes and build the wheel package and upload it to your private artifact platform. |
Currently, this package declares that it needs Python >= 3.9, and so pip will not allow you to install it on earlier Python versions.
However, this package actually works fine on Python 3.8; I force-installed it using
pip install 'shfmt-py~=3.11' --ignore-requires-pythonand it installed and worked with no issues.The only reason that this package is currently set to require Python >= 3.9 is because that's the default
min-py-versionfor the setup_cfg_fmt autoformatter, and so the formatter automatically changed the value in this repo's setup.cd (see commit e710e89). This PR updates the pre-commit config to pass--min-py-version '3.8'to setup_cfg_fmt