Add unit tests for RequestBuilder#8
Closed
lennartbecker-d wants to merge 31 commits intoMaximilianToe:mainfrom
Closed
Add unit tests for RequestBuilder#8lennartbecker-d wants to merge 31 commits intoMaximilianToe:mainfrom
lennartbecker-d wants to merge 31 commits intoMaximilianToe:mainfrom
Conversation
… method, which is currently in dev
Rpc client u subscription
|
Code coverage report is ready! 📈
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing the subscription request and its attributes seems to be complicated.
Also see Consumer.h -> Components like USubscriptionUuriBuilder (currently implemented in Consumer and in own document) do not have any unit tests yet. Mocking the transport and the client might work well with consumer example.