Fix UnionFileSystemProvider#newDirectoryStream to obey contract of FileSystemProvider#newDirectoryStream
#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`FileSystemProvider#newDirectoryStream` Fixes McModLauncher#78
marchermans
approved these changes
May 31, 2025
shartte
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78; use of
Files.walkshould now producePaths that are as if resolved from the root path. This required a change toJarContentsImplas it relied on the old (incorrect!) behavior wherewalkreturned explicitly relative paths no matter what, as well as some changes to certain tests where similar assumptions were made.