bfpxe: Improve MAC address parsing#235
Open
pawel-baldysiak-dell wants to merge 1 commit intoMellanox:masterfrom
Open
bfpxe: Improve MAC address parsing#235pawel-baldysiak-dell wants to merge 1 commit intoMellanox:masterfrom
pawel-baldysiak-dell wants to merge 1 commit intoMellanox:masterfrom
Conversation
Currently "bfmac=" param expects MAC address to follow "aa-bb-cc-dd-ee-ff" format, however standard defines that it might also be "aa:bb:cc:dd:ee:ff". Change the way how "bfmac=" param is parsed, so it accepts both formats. Signed-off-by: Pawel Baldysiak <pawel.baldysiak@dell.com>
mahantesh-nvidia
approved these changes
Sep 24, 2024
Collaborator
mahantesh-nvidia
left a comment
mahantesh-nvidia
left a comment
There was a problem hiding this comment.
This implementation is backward compatible and also handles grub format. This is efficient because the mac is required to be in the same format as grub stores is it, for finding the matching interface name from /sys/class/net/*/address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently "bfmac=" param expects MAC address to follow "aa-bb-cc-dd-ee-ff" format, however standard defines that it might also be "aa:bb:cc:dd:ee:ff".
Change the way how "bfmac=" param is parsed, so it accepts both formats.