Skip to content

Foreign key child feature fix #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-bolbotina wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Foreign key child feature fix #4356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9024ce8
Initial draft
gabriel-bolbotina Feb 27, 2026
0774278
Renamed variables
gabriel-bolbotina Mar 2, 2026
c49f6f0
Simplified prefillRelationReferenceField function
gabriel-bolbotina Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app/attributes/attributecontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,16 @@ void AttributeController::prefillRelationReferenceField()
const QList<QgsRelation::FieldPair> fieldPairs = mLinkedRelation.fieldPairs();
for ( const QgsRelation::FieldPair &fieldPair : fieldPairs )
{
QMap<QUuid, std::shared_ptr<FormItem>>::iterator formItemsIterator = mFormItems.begin();
while ( formItemsIterator != mFormItems.end() )
QVariant foreignKey = mParentController->featureLayerPair().feature().attribute( fieldPair.referencedField() );
QString referencingField = fieldPair.referencingField();
QgsVectorLayer *childLayer = mLinkedRelation.referencingLayer();
Copy link
Contributor

@Withalion Withalion Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
QgsVectorLayer *childLayer = mLinkedRelation.referencingLayer();
const QgsVectorLayer *childLayer = mLinkedRelation.referencingLayer();

if ( childLayer )
{
std::shared_ptr<FormItem> itemData = formItemsIterator.value();
if ( itemData->field().name() == fieldPair.referencingField() )
int fieldIndex = childLayer->fields().lookupField( referencingField );
Copy link
Contributor

@Withalion Withalion Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int fieldIndex = childLayer->fields().lookupField( referencingField );
const int fieldIndex = childLayer->fields().lookupField( referencingField );

if ( fieldIndex != -1 )
{
QVariant fk = mParentController->featureLayerPair().feature().attribute( fieldPair.referencedField() );
setFormValue( itemData->id(), fk );
break;
mFeatureLayerPair.featureRef().setAttribute( fieldIndex, foreignKey );
}
++formItemsIterator;
}
}
}
Expand Down
Loading