Fix position bugs by Withalion · Pull Request #4360 · MerginMaps/mobile

Withalion · 2026-03-02T15:27:36Z

Fixes these minor bugs:

Fixes elevation available outside local geoid models.
Adds geoid model info button for internal providers
Fixes translation for geoid model info bubble

tomasMizera

I was thinking that it would be good to show the info icon (which geoid is used) all the time. I think it will now be quite random for users to tell when the icon is visible and when not.

app/position/positionkit.cpp

github-actions · 2026-03-02T15:42:54Z

Pull Request Test Coverage Report for Build 22582649795

Details

0 of 0 changed or added relevant lines in 0 files are covered.
89 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.1%) to 59.767%

Files with Coverage Reduction	New Missed Lines	%
mm/core/merginuserauth.cpp	9	68.24%
mm/app/position/positiontransformer.cpp	11	84.96%
mm/core/merginapi.cpp	13	75.07%
mm/app/position/positionkit.cpp	56	67.7%

Totals
Change from base Build 22568885959:	-0.1%
Covered Lines:	8769
Relevant Lines:	14672

💛 - Coveralls

Withalion · 2026-03-02T15:42:56Z

We can show the icon all the time, but sometimes we have no clue what model is used to calculate the final value. So, do we want to show something like "Orthometric height, using unknown geoid model"?

github-actions · 2026-03-02T15:47:53Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 64391 dmg	Expires: 31/05/2026	#6439
linux Build	📬	Mergin Maps 64501 x86_64	Expires: 31/05/2026	#6450
win64 Build	📬	Mergin Maps 56341 win64	Expires: 31/05/2026	#5634
Android Build	📭	Build not yet complete or failed.
iOS Build	📬		Build number: 26.03.869011	#8690

github-actions · 2026-03-02T16:52:01Z

📦 Build Artifacts Ready

OS	Status	Build	Info	Workflow run
macOS Build	📬	Mergin Maps 64431 dmg	Expires: 31/05/2026	#6443
linux Build	📭	Build not yet complete or failed.
win64 Build	📬	Mergin Maps 56381 win64	Expires: 31/05/2026	#5638
Android Build	📬	Mergin Maps 775351 APK [arm64-v8a]	Expires: 31/05/2026	#7753
Android Build	📬	Mergin Maps 775311 APK [armeabi-v7a]	Expires: 31/05/2026	#7753
iOS Build	📬		Build number: 26.03.869411	#8694

RastoHu · 2026-03-04T16:19:22Z

@tomasMizera @Withalion @IvaKuklica please find the issues from testing. I suggest to discuss the ❌ and ❓ points.

Testing Geoid heights

iOS - External GPS (RX):

project with NON EGM model set
-> Source: External (Mock) OK
-> (i): Elevation using unspecified grid OK
-> (i): translated to Slovak OK
-> Geoid separation: N/A OK
-> Altitude (antenna height set to 0.145 m): 130.16 m
-> Altitude (antenna height set to 0 m): 130.30 m
-> Horizontal accuracy: 5.00 m (constant) ℹ️ BUG #4090
-> Vertical accuracy: 9.50 m (constant) ℹ️ BUG #4090
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_elevation_ellipsoid : NULL ok, if Geoid separation is NULL ✅
-> form variable @position_geoid_separation: NULL ✅
project: test_external_receiver_world (EGM2008)
-> Source: External (Mock) OK
-> (i): Orthometric height, using EGM2008 height geoid OK
-> (i): translated to Slovak ✅: ~~Ortometrická výška, podľa EGM2008 height geoidu~~
-> Geoid separation: 43.55 m OK
-> Altitude (antenna height set to 0.145 m): 86.61 m ❓ BUG
-> Altitude (antenna height set to 0 m): 86.75 m ❓ BUG
-> Horizontal accuracy: 5.00 m (constant) ℹ️ BUG #4090
-> Vertical accuracy: 9.50 m (constant) ℹ️ BUG #4090
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_elevation_ellipsoid : 130.155 ❓ BUG
-> form variable @position_geoid_separation: 43.547 OK
project: test_external_receiver_martinique (IGN 1987)
-> Source: External (Mock) OK
-> (i): Orthometric height, using IGN 1987 (MARTINUQE) geoid ✅ ~~missing word height in "...(MARTINUQE) height geoid"~~
-> (i): translated to Slovak OK
-> Geoid separation: N/A m OK
-> Altitude (antenna height set to 0.145 m): N/A m OK
-> Altitude (antenna height set to 0 m): N/A m OK
-> Horizontal accuracy: 5.00 m (constant) ℹ️ BUG #4090
-> Vertical accuracy: 9.50 m (constant) ℹ️ BUG #4090
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_geoid_separation: NaN OK

iOS - Internal GPS:

project with NON EGM model set
-> Source: Internal OK
-> (i): Orthometric height, using EGM96 height geoid OK
-> (i): translated to Slovak ✅ : ~~Ortometrická výška, podľa EGM96 height geoidu~~
-> Geoid separation: 43.62 OK
-> Altitude (antenna height set to 0 m): 126.53 m
-> Horizontal accuracy: 2.67 m OK
-> Vertical accuracy: 4.03 m OK
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_elevation_ellipsoid : 173.701 m OK
-> form variable @position_geoid_separation: 43.618 m OK
project: test_external_receiver_world (EGM2008)
-> Source: Internal OK
-> (i): Orthometric height, using EGM2008 height geoid OK
-> (i): translated to Slovak ✅ : ~~Ortometrická výška, podľa EGM2008 height geoidu~~
-> Geoid separation: 43.55 m OK
-> Altitude (antenna height set to 0 m): 127.57 m
-> Horizontal accuracy: 2.93 m OK
-> Vertical accuracy: 5.53 m OK
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_elevation_ellipsoid : 169.853 OK
-> form variable @position_geoid_separation: 43.547 OK
project: test_external_receiver_martinique (IGN 1987)
-> Source: Internal OK
-> (i): Orthometric height, using IGN 1987 (MARTINUQE) geoid ✅ ~~missing word height in "...(MARTINUQE) height geoid"~~
-> (i): translated to Slovak OK
-> Geoid separation: N/A OK
-> Altitude (antenna height set to 0 m): N/A OK
-> Horizontal accuracy: 3.21 m OK
-> Vertical accuracy: 6.30 m OK
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_geoid_separation: NULL OK

Android - External Mock (RX):

project with NON EGM model set
-> Source: External (Mock) OK
-> (i): Elevation using unspecified grid OK
-> (i): translated to Slovak OK
-> Geoid separation: N/A OK
-> Altitude (antenna height set to 0.145 m): 171.51 m ✅ probably ok, because NTRIP app returns Ellipsoidal Height (set in app)
-> Altitude (antenna height set to 0 m): 171.65 m
-> Horizontal accuracy: 0.01 m (constant?) ❓ check again
-> Vertical accuracy: 0.02 m (constant?) ❓ check again
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_elevation_ellipsoid : NULL ✅
-> form variable @position_geoid_separation: NULL ✅
project: test_external_receiver_world (EGM2008)
-> Source: External (Mock) OK
-> (i): Orthometric height, using EGM2008 height geoid OK
-> (i): translated to Slovak ✅ : ~~Ortometrická výška, podľa EGM2008 height geoidu~~
-> Geoid separation: 43.55 m OK
-> Altitude (antenna height set to 0.145 m): 127.93 m OK
-> Altitude (antenna height set to 0 m): 128.08 m OK
-> Horizontal accuracy: 0.01 m (constant?)❓ check again
-> Vertical accuracy: 0.02 m (constant?)❓ check again
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_elevation_ellipsoid : 171.507 OK
-> form variable @position_geoid_separation: 43.547 OK
project: test_external_receiver_martinique (IGN 1987)
-> Source: External (Mock) OK
-> (i): Orthometric height, using IGN 1987 (MARTINUQE) geoid ✅ ~~missing word height in "...(MARTINUQE) height geoid"~~
-> (i): translated to Slovak OK
-> Geoid separation: N/A m OK
-> Altitude (antenna height set to 0.145 m): N/A m OK
-> Altitude (antenna height set to 0 m): N/A m OK
-> Horizontal accuracy: 0.01 m (constant?)❓ check again
-> Vertical accuracy: 0.02 m (constant?)❓ check again
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_geoid_separation: NULL OK

Android - Internal GPS:

project with NON EGM model set
-> Source: Internal OK
-> (i): Orthometric height, using EGM96 height geoid OK
-> (i): translated to Slovak ✅ : ~~Ortometrická výška, podľa EGM96 height geoidu~~
-> Geoid separation: 43.62 OK
-> Altitude (antenna height set to 0 m): 122.44 m
-> Horizontal accuracy: 1.80 m OK
-> Vertical accuracy: 12.20 m OK
-> Satellites (in use/view): 26/53 OK
-> form variable @position_elevation_ellipsoid : 169.355 m OK
-> form variable @position_geoid_separation: 43.618 m OK
project: test_external_receiver_world (EGM2008)
-> Source: Internal OK
-> (i): Orthometric height, using EGM2008 height geoid OK
-> (i): translated to Slovak ✅ : ~~Ortometrická výška, podľa EGM2008 height geoidu~~
-> Geoid separation: 43.55 m OK
-> Altitude (antenna height set to 0 m): 121.15 m
-> Horizontal accuracy: 1.70 m OK
-> Vertical accuracy: 10.40 m OK
-> Satellites (in use/view): 21/54 OK
-> form variable @position_elevation_ellipsoid : 175.2 OK
-> form variable @position_geoid_separation: 43.547 OK
project: test_external_receiver_martinique (IGN 1987)
-> Source: Internal OK
-> (i): Orthometric height, using IGN 1987 (MARTINUQE) geoid ✅ ~~missing word height in "...(MARTINUQE) height geoid"~~
-> (i): translated to Slovak OK
-> Geoid separation: N/A OK
-> Altitude (antenna height set to 0 m): N/A OK
-> Horizontal accuracy: 1.70 m OK
-> Vertical accuracy: 13.10 m OK
-> Satellites (in use/view): N/A ℹ️ BUG #4090
-> form variable @position_geoid_separation: NULL OK

Android - External Bluetooth (RX):

project with NON EGM model set
-> Source: RX OK
-> (i): Elevation using unspecified grid OK
-> (i): translated to Slovak OK
-> Geoid separation: 41.22 ✅ - should be displayed?
-> Altitude (antenna height set to 0 m): 129.42 m
-> Horizontal accuracy: 0.21 m
-> Vertical accuracy: 0.30 m
-> Satellites (in use/view): 30/32 OK
-> form variable @position_elevation_ellipsoid : 171.102 m OK
-> form variable @position_geoid_separation: 41.223 m ✅
project: test_external_receiver_world (EGM2008)
-> Source: RX OK
-> (i): Orthometric height, using EGM2008 height geoid OK
-> (i): translated to Slovak ✅ : ~~Ortometrická výška, podľa EGM2008 height geoidu~~
-> Geoid separation: 43.55 m OK
-> Altitude (antenna height set to 0 m): 127.47 m OK
-> Horizontal accuracy: 0.19 m
-> Vertical accuracy: 0.29 m
-> Satellites (in use/view): 28/32 OK
-> form variable @position_elevation_ellipsoid : 171.212 OK
-> form variable @position_geoid_separation: 43.547 OK
project: test_external_receiver_martinique (IGN 1987)
-> Source: RX OK
-> (i): Orthometric height, using IGN 1987 (MARTINUQE) geoid ✅ ~~missing word height in "...(MARTINUQE) height geoid"~~
-> (i): translated to Slovak OK
-> Geoid separation: N/A m OK
-> Altitude (antenna height set to 0 m): N/A m OK
-> Horizontal accuracy: 0.19 m
-> Vertical accuracy: 0.30 m
-> Satellites (in use/view): 29/31 OK
-> form variable @position_geoid_separation: NULL OK

Issues:

External (Mocked), Android, iOS: When downloading and opening a project for the first time, the GPS Info panel displays data from the previously opened project. A mobile app restart is required for the GPS Info panel to refresh and show the correct data. ℹ️ GPS Info panel shows stale data from previously opened project #4372

Withalion added 3 commits March 2, 2026 11:02

Fix elevation available when it shouldn't be

e2cbbef

Fix info button in GPS panel

926a020

Fix layout

09d26cd

Withalion added this to the 2026.1.1 milestone Mar 2, 2026

Withalion requested review from gabriel-bolbotina and tomasMizera March 2, 2026 15:27

Withalion self-assigned this Mar 2, 2026

tomasMizera reviewed Mar 2, 2026

View reviewed changes

app/position/positionkit.cpp Show resolved Hide resolved

Withalion added 4 commits March 2, 2026 17:05

Return EGM96 only for not mocked position on iOS

a818ab1

Fix elevation info

a473b64

Update translatable strings

2af291e

Fix formatting

00aac6b

tomasMizera approved these changes Mar 2, 2026

View reviewed changes

Withalion merged commit 59b4851 into master Mar 2, 2026
11 of 12 checks passed

Withalion deleted the fix/position-panel branch March 2, 2026 17:23

Withalion added test - failure QA team rejected the item and removed test - failure QA team rejected the item labels Mar 3, 2026

Withalion mentioned this pull request Mar 5, 2026

Position variables not available/populated (@position_vertical_speed, @position_magnetic_variation); on iOS satellites info missing and “-1” values #4090

Open

Withalion added the test - success QA team accepted the item label Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix position bugs#4360

Fix position bugs#4360
Withalion merged 7 commits intomasterfrom
fix/position-panel

Withalion commented Mar 2, 2026 •

edited

Loading

Uh oh!

tomasMizera left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Withalion commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Uh oh!

RastoHu commented Mar 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Withalion commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomasMizera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Pull Request Test Coverage Report for Build 22582649795

Details

💛 - Coveralls

Uh oh!

Withalion commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

📦 Build Artifacts Ready

Uh oh!

github-actions bot commented Mar 2, 2026

📦 Build Artifacts Ready

Uh oh!

Uh oh!

RastoHu commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Geoid heights

iOS - External GPS (RX):

iOS - Internal GPS:

Android - External Mock (RX):

Android - Internal GPS:

Android - External Bluetooth (RX):

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Withalion commented Mar 2, 2026 •

edited

Loading

RastoHu commented Mar 4, 2026 •

edited

Loading