fixes failures on expression-bodied constructors #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes enable support for expression-bodied constructors, such as:
the above code as is fails in the current implementation, the proposed modification fixes the failure.
additionally, I further proposed other changes regarding the internal
UdonSharpInternalUtility.GetTypeIDutilitarian subroutine, those changes preserve the previous behaviour of the subroutine; therefore the changes are benign. it is mainly for modernization reasons (although it is slightly more performant).is
SHA256really needed for the purpose of hashing? if not, will it be a breaking change to use a much more efficient algorithm?I had
XxHash64.HashToUInt64(fromSystem.IO.Hashing) in mind as a much, much faster and memory efficient alternative; if there isn't much interest in improving performance, then don't mind my suggestion.