Open
Conversation
…or-debug-level2 Made-with: Cursor
Signed-off-by: Max Raiskii <max.raiskii@meshinspector.com>
Signed-off-by: Max Raiskii <max.raiskii@meshinspector.com>
MaxRayskiy
added
skip-image-rebuild
Grantim
reviewed
Apr 1, 2026
| output_zip: MeshLibDist.zip | ||
| artifact_name: DistributivesWin | ||
| - vcpkg_triplet: x64-windows-meshlib-iterator-debug | ||
| extract_release: MREDist_Release-IteratorDebug.zip |
Contributor
There was a problem hiding this comment.
it seems strange, do we have Release with changed iterator debug level?
Comment on lines
+12
to
+14
| # MSVC: _ITERATOR_DEBUG_LEVEL > 1 is invalid in Release (see yvals.h C1189) | ||
| set(VCPKG_CXX_FLAGS_RELEASE "${VCPKG_CXX_FLAGS_RELEASE} /D_ITERATOR_DEBUG_LEVEL=0") | ||
| set(VCPKG_C_FLAGS_RELEASE "${VCPKG_C_FLAGS_RELEASE} /D_ITERATOR_DEBUG_LEVEL=0") No newline at end of file |
Contributor
There was a problem hiding this comment.
do we need to set it explicitly?
Fedr
reviewed
Apr 1, 2026
| set(MESHLIB_BUILD_MESHCONV OFF) | ||
| ENDIF() | ||
|
|
||
| # Python modules are incompatible with _ITERATOR_DEBUG_LEVEL=2 because the |
Contributor
There was a problem hiding this comment.
may be check then that we are building Debug configuration, since Release configuration will not have any problems with this triplet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.