Skip to content

Fix intent for fill procedures #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adam Maycock (adammaycock) merged 1 commit into from
Apr 7, 2026
Merged

Fix intent for fill procedures #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/opsinputs/opsinputs_fill_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ subroutine opsinputs_fill_fillreal( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(real64), pointer, intent(out) :: Real1(:)
real(real64), pointer, intent(inout) :: Real1(:)
type(c_ptr), value, intent(in) :: ObsSpace
character(len=*), intent(in) :: JediVarName
character(len=*), intent(in) :: JediVarGroup
Expand Down Expand Up @@ -1051,7 +1051,7 @@ subroutine opsinputs_fill_fillreal2d_norecords( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
integer(integer64), intent(in) :: NumObs
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(c_int), intent(in) :: Channels(:)
character(len=*), intent(in) :: JediVarName
Expand Down Expand Up @@ -1179,7 +1179,7 @@ subroutine opsinputs_fill_fillreal2d_records( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(integer64), intent(in) :: VarobsLength
character(len=*), intent(in) :: JediVarName
Expand Down Expand Up @@ -1269,7 +1269,7 @@ subroutine opsinputs_fill_fillreal2d( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(c_int), intent(in) :: Channels(:)
integer(integer64), intent(in) :: VarobsLength
Expand Down Expand Up @@ -1354,7 +1354,7 @@ subroutine opsinputs_fill_fillrealfromgeoval( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
integer(integer64), intent(in) :: NumObs
real(real64), pointer, intent(out) :: Real1(:)
real(real64), pointer, intent(inout) :: Real1(:)
type(ufo_geovals), intent(in) :: GeoVals
character(len=*), intent(in) :: JediVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
Expand Down Expand Up @@ -1443,7 +1443,7 @@ subroutine opsinputs_fill_fillreal2dfromgeoval( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
integer(integer64), intent(in) :: NumObs
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(ufo_geovals), intent(in) :: GeoVals
logical, intent(in) :: GeoVaLsAreTopToBottom
character(len=*), intent(in) :: JediVarName
Expand Down Expand Up @@ -1578,7 +1578,7 @@ subroutine opsinputs_fill_fillreal2dfromhofx( &
! Subroutine arguments:
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(c_double), intent(in) :: hofx(:)
character(len=*), intent(in) :: JediVarName
Expand Down Expand Up @@ -1654,7 +1654,7 @@ subroutine opsinputs_fill_fillrealfromgeovalformultilevelobs( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
integer(integer64), intent(in) :: NumObs
real(real64), pointer, intent(out) :: Real1(:)
real(real64), pointer, intent(inout) :: Real1(:)
character(len=*), intent(in) :: JediVarName
type(ufo_geovals), intent(in) :: GeoVals
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
Expand Down Expand Up @@ -1718,7 +1718,7 @@ subroutine opsinputs_fill_fillreal2dfromgeovalformultilevelobs( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
integer(integer64), intent(in) :: NumObs
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
character(len=*), intent(in) :: JediVarName
type(ufo_geovals), intent(in) :: GeoVals
logical, intent(in) :: GeoVaLsAreTopToBottom
Expand Down Expand Up @@ -1875,7 +1875,7 @@ subroutine opsinputs_fill_fillinteger2d( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
integer(integer64), pointer, intent(out) :: Int2(:,:)
integer(integer64), pointer, intent(inout) :: Int2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(c_int), intent(in) :: Channels(:)
integer(integer64), intent(in) :: VarobsLength
Expand Down Expand Up @@ -2049,7 +2049,7 @@ subroutine opsinputs_fill_filltimeoffsets( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(real64), pointer, intent(out) :: Real1(:)
real(real64), pointer, intent(inout) :: Real1(:)
type(c_ptr), value, intent(in) :: ObsSpace
character(len=*), intent(in) :: JediVarName
character(len=*), intent(in) :: JediVarGroup
Expand Down Expand Up @@ -2125,7 +2125,7 @@ subroutine opsinputs_fill_filltimeoffsets2d_norecords( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
integer(integer64), intent(in) :: NumObs
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(c_int), intent(in) :: Channels(:)
character(len=*), intent(in) :: JediVarName
Expand Down Expand Up @@ -2200,7 +2200,7 @@ subroutine opsinputs_fill_filltimeoffsets2d_records( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(integer64), intent(in) :: VarobsLength
character(len=*), intent(in) :: JediVarName
Expand Down Expand Up @@ -2297,7 +2297,7 @@ subroutine opsinputs_fill_filltimeoffsets2d( &
type(ElementHeader_Type), intent(inout) :: Hdr
character(len=*), intent(in) :: OpsVarName
type(opsinputs_jeditoopslayoutmapping), intent(in) :: JediToOpsLayoutMapping
real(real64), pointer, intent(out) :: Real2(:,:)
real(real64), pointer, intent(inout) :: Real2(:,:)
type(c_ptr), value, intent(in) :: ObsSpace
integer(c_int), intent(in) :: Channels(:)
integer(integer64), intent(in) :: VarobsLength
Expand Down
Loading