Skip to content

Conversation

@HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented May 31, 2024

Description

  • Updates Yarn to the latest version: 4.2.2
  • Removes the yarn-*.cjs files from our repo (see this discussion about how these 2.6MB files shouldn't be committed)
  • Now using corepack enable in CircleCI

This is very similar to MetaMask/metamask-module-template#243

Open in GitHub Codespaces

Related issues

Similar: MetaMask/metamask-module-template#243

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham HowardBraham marked this pull request as ready for review May 31, 2024 01:38
@HowardBraham HowardBraham requested review from a team and kumavis as code owners May 31, 2024 01:38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it with with just corepack enable sans sudo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.79%. Comparing base (5f22357) to head (39fd66a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24930   +/-   ##
========================================
  Coverage    65.79%   65.79%           
========================================
  Files         1364     1364           
  Lines        54315    54315           
  Branches     14126    14126           
========================================
  Hits         35732    35732           
  Misses       18583    18583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e8bc321]
Page Load Metrics (660 ± 484 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint662101022914
domContentLoaded9111192210
load5931616601008484
domInteractive9111192210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

legobeat
legobeat previously approved these changes May 31, 2024
mcmire
mcmire previously approved these changes May 31, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@HowardBraham HowardBraham dismissed stale reviews from mcmire and legobeat via 176984d May 31, 2024 05:17
legobeat
legobeat previously approved these changes May 31, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [176984d]
Page Load Metrics (107 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint621017994
domContentLoaded9121010
load421219107255123
domInteractive9121010

@metamaskbot
Copy link
Collaborator

Builds ready [39fd66a]
Page Load Metrics (232 ± 256 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7212088115
domContentLoaded9301463
load442025232533256
domInteractive9301463

@legobeat legobeat merged commit 0b0bf11 into develop May 31, 2024
@legobeat legobeat deleted the update-yarn branch May 31, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
@legobeat
Copy link
Contributor

legobeat commented Jun 1, 2024

@HowardBraham This broke some GitHub Actions workflows..
Fixed in:

@benjisclowder benjisclowder added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
@HowardBraham HowardBraham added contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-12.0.0 Issue or pull request that will be included in release 12.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants