-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: add monad network #37283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add monad network #37283
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +163 -8)
🔄 @MetaMask/swaps-engineers (2 files, +17 -3)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c245193]
UI Startup Metrics (1201 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
70709c4 to
41e7eb1
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [41e7eb1]
UI Startup Metrics (1268 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
stanleyyconsensys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some conflict need to resolve
and double check if we need to patch as well (network enablement controller)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Builds ready [10031f0]
UI Startup Metrics (1264 ± 85 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [a25c11d]
UI Startup Metrics (1219 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asset CO file change LGTM, very minimal changes on our side.
Builds ready [7c3ba11]
UI Startup Metrics (1262 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
stanleyyconsensys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [ec82bac]
UI Startup Metrics (1337 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ameliejyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from core extension UX side. What is neNetwork though, is it meant to be newNetwork? I see it's in lots of places so out of the scope of this PR but just wondering.
Description
This PR:
Adds MONAD network as additional network
Support Bridge & Swap for MONAD network
Changelog
CHANGELOG entry: adds MONAD network with bridge & swap support
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds Monad network across constants, bridge and swaps allowlists, UI, security mapping, and tests; includes icon/explorer/RPC config and lowers token occurrence threshold; bumps network-enablement-controller.
CHAIN_IDS.MONAD, display name, currencyMON, icons (app/images/monad.svg), block explorer (monadscan.com) and portfolio URL mappings.FEATURED_RPCSwith Infura RPC; update image/token maps and currency symbol maps.MINIMUM_TOKEN_OCCURRENCESand addTOKEN_OCCURRENCES_MAP[MONAD]=1.ALLOWED_EVM_BRIDGE_CHAIN_IDSand CAIP maps; add short-name mapping and common token pair (USDCon Monad).WMON) and contract address; add stablecoin set (USDCon Monad) and string ID export.@metamask/network-enablement-controllerto^3.1.0(lockfile updated).Written by Cursor Bugbot for commit ec82bac. This will update automatically on new commits. Configure here.