Skip to content

Conversation

@khanti42
Copy link
Contributor

@khanti42 khanti42 commented Oct 27, 2025

Description

This PR:

Adds MONAD network as additional network
Support Bridge & Swap for MONAD network

Open in GitHub Codespaces

Changelog

CHANGELOG entry: adds MONAD network with bridge & swap support

Related issues

Fixes:

Manual testing steps

Feature: Add MONAD Network support

  Scenario: User adds and uses MONAD Network
    Given the user opens the app and is on the network selector screen
    When the user adds "Monad Network" as an additional network
    Then the "Monad Network" should appear in the list of available networks
    And the user should be able to select the "Monad Network" successfully

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Monad network across constants, bridge and swaps allowlists, UI, security mapping, and tests; includes icon/explorer/RPC config and lowers token occurrence threshold; bumps network-enablement-controller.

  • Networks/Config:
    • Add CHAIN_IDS.MONAD, display name, currency MON, icons (app/images/monad.svg), block explorer (monadscan.com) and portfolio URL mappings.
    • Include Monad in FEATURED_RPCS with Infura RPC; update image/token maps and currency symbol maps.
    • Export MINIMUM_TOKEN_OCCURRENCES and add TOKEN_OCCURRENCES_MAP[MONAD]=1.
  • Bridge:
    • Allow Monad in ALLOWED_EVM_BRIDGE_CHAIN_IDS and CAIP maps; add short-name mapping and common token pair (USDC on Monad).
    • Map Monad in Security Alerts API chain name; adjust tests (counts) accordingly.
  • Swaps:
    • Add Monad to allowed swaps chains, default token object, wrapped token (WMON) and contract address; add stablecoin set (USDC on Monad) and string ID export.
  • UI/Selectors:
    • Show Monad in network list menu (tests/snapshots updated) and token detection supported networks; update bridge selectors/tests.
    • Bridge prepare page uses per-chain token occurrence threshold.
  • Dependencies:
    • Bump @metamask/network-enablement-controller to ^3.1.0 (lockfile updated).

Written by Cursor Bugbot for commit ec82bac. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 27, 2025

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +163 -8)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 network-list-menu/
          • 📁 __snapshots__/
            • 📄 network-list-menu.test.tsx.snap +131 -5
            • 📄 network-list-menu.test.tsx +32 -3

🔄 @MetaMask/swaps-engineers (2 files, +17 -3)
  • 📁 ui/
    • 📁 ducks/
      • 📁 bridge/
        • 📄 selectors.test.ts +1 -1
    • 📁 pages/
      • 📁 bridge/
        • 📁 prepare/
          • 📄 prepare-bridge-page.tsx +16 -2

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: c245193 | Date: 10/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±69ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 71ms 1.00s 1.31s 1.27s 1.31s
domContentLoaded 727ms 69ms 691ms 997ms 943ms 997ms
firstPaint 75ms 12ms 56ms 168ms 84ms 168ms
firstContentfulPaint 75ms 12ms 56ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [c245193]
UI Startup Metrics (1201 ± 93 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1201101713899312621365
load102886912269010911190
domContentLoaded102186412189010851183
domInteractive201488111845
firstPaint62476123439610281144
backgroundConnect1891762217193202
firstReactRender28174873243
getState18884102137
initialActions50405616
loadScripts8386931025899001000
setupStore1061931218
BrowserifyPower User HomeuiStartup22551761411269329784112
load1182930210636215882106
domContentLoaded1172922209836115812098
domInteractive311590235290
firstPaint853170174646810071746
backgroundConnect273226696111270696
firstReactRender26233433134
getState17415526526177265
initialActions817417574
loadScripts929697171832613181718
setupStore1081211112
WebpackStandard HomeuiStartup8467281113718591029
load63258691061644754
domContentLoaded62457990260638746
domInteractive15115281435
firstPaint21156905223179740
backgroundConnect23124572637
firstReactRender27177493239
getState1152241318
initialActions3118349
loadScripts62157789057635734
setupStore1052431217
WebpackPower User HomeuiStartup17421484246334322072463
load72763610941298121094
domContentLoaded69761710411177841041
domInteractive20123693536
firstPaint5187610473137991047
backgroundConnect12522448138263448
firstReactRender26223642636
getState15914121922161219
initialActions13163213163
loadScripts69361510311147731031
setupStore24581295781
FirefoxBrowserifyStandard HomeuiStartup14791300199810415281680
load1267112015568013131398
domContentLoaded1267112015568013121398
domInteractive1173624544131216
firstPaint------
backgroundConnect4325131194995
firstReactRender25205262545
getState9318118814
initialActions318136
loadScripts1240110115137612811375
setupStore1274761316
BrowserifyPower User HomeuiStartup27312283363944129333639
load14151216174717014931747
domContentLoaded14141215174616914921746
domInteractive1528529962216299
firstPaint------
backgroundConnect25852748220435748
firstReactRender432977135377
getState1298120434146204
initialActions17173232373
loadScripts13451180163314114351633
setupStore311084214984
WebpackStandard HomeuiStartup15921406213212216281839
load1366119917289814131536
domContentLoaded1366119817289814121536
domInteractive1113038665113296
firstPaint------
backgroundConnect4722100175581
firstReactRender292279112866
getState9414314818
initialActions511901936
loadScripts1338118016959413731502
setupStore13658101345
WebpackPower User HomeuiStartup27732287369137630283691
load15941274192120917911921
domContentLoaded15941273192120917911921
domInteractive1445724351190243
firstPaint------
backgroundConnect16242620144282620
firstReactRender39315684856
getState1367823447190234
initialActions71266926
loadScripts15411253189120017491891
setupStore301274173674
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.45 KiB (-0.03%)
  • ui: 3.82 KiB (0.05%)
  • common: 6.68 KiB (0.08%)

@khanti42 khanti42 force-pushed the feat/add-monad-network branch from 70709c4 to 41e7eb1 Compare October 28, 2025 08:52
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 41e7eb1 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 716ms (±40ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 43ms 1.00s 1.33s 1.06s 1.33s
domContentLoaded 716ms 40ms 694ms 1.00s 752ms 1.00s
firstPaint 76ms 10ms 60ms 160ms 84ms 160ms
firstContentfulPaint 76ms 10ms 60ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [41e7eb1]
UI Startup Metrics (1268 ± 79 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1268110514387913221419
load109095412747911381220
domContentLoaded108494812677811311210
domInteractive20146391846
firstPaint785143127343011321217
backgroundConnect2312182537236246
firstReactRender27175273142
getState19780102234
initialActions50788615
loadScripts860721104577914983
setupStore1072931014
BrowserifyPower User HomeuiStartup21461845335146823223351
load1073895156724413621567
domContentLoaded1062889155623913441556
domInteractive271461154161
firstPaint79223215614139761561
backgroundConnect252188588112266588
firstReactRender25212822528
getState20312834145209341
initialActions11167161067
loadScripts851693129321110581293
setupStore1382972029
WebpackStandard HomeuiStartup8727341069709151017
load66959187276715849
domContentLoaded66258486576709840
domInteractive16115881434
firstPaint18459851169197610
backgroundConnect23134272839
firstReactRender25165783335
getState1152541417
initialActions30183413
loadScripts65858186375700830
setupStore941631214
WebpackPower User HomeuiStartup15911141236232417532362
load658563934125721934
domContentLoaded62454980689677806
domInteractive191249113249
firstPaint45895847278726847
backgroundConnect81182768987276
firstReactRender24212822628
getState1704021337179213
initialActions11145152145
loadScripts62154779887668798
setupStore24659173359
FirefoxBrowserifyStandard HomeuiStartup15461344204212916011838
load1311116416439513671487
domContentLoaded1310116316439513661486
domInteractive1203626542138211
firstPaint------
backgroundConnect47261452353104
firstReactRender27216272750
getState11425926913
initialActions4136448
loadScripts1280109416129413341464
setupStore167195211337
BrowserifyPower User HomeuiStartup27562390396146728253961
load1424132515968115101596
domContentLoaded1424132515968015091596
domInteractive16610830966245309
firstPaint------
backgroundConnect15636510169269510
firstReactRender41316084660
getState1674724746212247
initialActions1421303113130
loadScripts1387126615537714651553
setupStore3361804738180
WebpackStandard HomeuiStartup16221396216214316931965
load13821177170011314661599
domContentLoaded13821177169911314651599
domInteractive1142547973113264
firstPaint------
backgroundConnect4722137205684
firstReactRender27227562835
getState846971014
initialActions4170839
loadScripts13541160166811114371572
setupStore167121171351
WebpackPower User HomeuiStartup29532429396550733953965
load16211296211722417602117
domContentLoaded16211296211622417592116
domInteractive1448328261206282
firstPaint------
backgroundConnect23831794278491794
firstReactRender443083155383
getState17510224847227248
initialActions11180191280
loadScripts15581278191218317281912
setupStore2762024727202
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 28 Bytes (0%)
  • common: 1.28 KiB (0.01%)

Copy link
Contributor

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some conflict need to resolve

and double check if we need to patch as well (network enablement controller)

@socket-security
Copy link

socket-security bot commented Nov 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​network-enablement-controller@​3.0.0 ⏵ 3.1.099 +110010096 +1100

View full report

@socket-security
Copy link

socket-security bot commented Nov 3, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [10031f0]
UI Startup Metrics (1264 ± 85 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1264110014348513331401
load108594512317911481207
domContentLoaded107893712237811411193
domInteractive211468121852
firstPaint63574123944110891198
backgroundConnect2302162919232247
firstReactRender301989103647
getState20983102236
initialActions61446717
loadScripts855703100378923970
setupStore1163641116
numNetworkReqs1367620672
BrowserifyPower User HomeuiStartup20221795272230224282722
load1079938147320313981473
domContentLoaded1072933146520313911465
domInteractive291580214980
firstPaint75418114193609731419
backgroundConnect23822030921247309
firstReactRender26253012730
getState18416222719200227
initialActions315145
loadScripts843713117218811631172
setupStore1192741127
numNetworkReqs18110133893312338
WebpackStandard HomeuiStartup8737371224968811175
load651593100386657916
domContentLoaded64358798682647900
domInteractive16126081537
firstPaint19657989200188733
backgroundConnect281296183077
firstReactRender28184573437
getState1263241517
initialActions3118349
loadScripts63958597580645889
setupStore1152331316
numNetworkReqs1367519871
WebpackPower User HomeuiStartup13811169191424015291914
load714606978144940978
domContentLoaded694593934135915934
domInteractive251374204174
firstPaint360106968286605968
backgroundConnect69183057865305
firstReactRender26233022630
getState14911817316156173
initialActions60359935
loadScripts689591923131902923
setupStore961531215
numNetworkReqs19110027560233275
FirefoxBrowserifyStandard HomeuiStartup14781301214113615251700
load1255109215489013101407
domContentLoaded1254109215479013101407
domInteractive1183534552122216
firstPaint------
backgroundConnect4225114194687
firstReactRender26215562642
getState9422322717
initialActions7221222318
loadScripts1228107314658512801384
setupStore1367291228
numNetworkReqs1266516763
BrowserifyPower User HomeuiStartup27452340415255930634152
load15211241214229418322142
domContentLoaded15201240214229418322142
domInteractive22599671183463671
firstPaint------
backgroundConnect14636439127211439
firstReactRender493599185399
getState1459520730172207
initialActions2021333910133
loadScripts14761211201527917972015
setupStore4981945570194
numNetworkReqs1606733397251333
WebpackStandard HomeuiStartup17261535245417717522158
load14611272196912715101692
domContentLoaded14601272196812715091692
domInteractive1123330642123179
firstPaint------
backgroundConnect58292663959127
firstReactRender362480153678
getState955661017
initialActions61507420
loadScripts14251213187611214781624
setupStore198242271456
numNetworkReqs1366818766
WebpackPower User HomeuiStartup25112142305427828253054
load15261278178516216311785
domContentLoaded15261277178516216311785
domInteractive17237484136348484
firstPaint------
backgroundConnect863218346124183
firstReactRender40305795157
getState13510620829150208
initialActions712561025
loadScripts14911249175816016061758
setupStore3972095044209
numNetworkReqs1646732881210328
📊 Page Load Benchmark Results

Current Commit: 10031f0 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±70ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 72ms 1.01s 1.33s 1.28s 1.33s
domContentLoaded 737ms 70ms 703ms 1.01s 952ms 1.01s
firstPaint 77ms 10ms 64ms 168ms 84ms 168ms
firstContentfulPaint 77ms 10ms 64ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 75 Bytes (0%)
  • ui: 28 Bytes (0%)
  • common: 1.31 KiB (0.02%)

@khanti42 khanti42 marked this pull request as ready for review November 3, 2025 08:42
@khanti42 khanti42 requested a review from a team as a code owner November 3, 2025 08:42
cursor[bot]

This comment was marked as outdated.

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Nov 4, 2025
@khanti42 khanti42 moved this from Needs dev review to Has approvals, needs CODEOWNER in PR review queue Nov 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a25c11d]
UI Startup Metrics (1219 ± 90 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1219107514869012651436
load104193512927810831210
domContentLoaded103392712817810801197
domInteractive211475141858
firstPaint61389120641810531166
backgroundConnect23522027411238259
firstReactRender24175162540
getState2074982338
initialActions60396623
loadScripts806676103978853964
setupStore1063031013
numNetworkReqs1367620672
BrowserifyPower User HomeuiStartup20431762321841223953218
load1058899162122713511621
domContentLoaded1047892161222113051612
domInteractive301579225079
firstPaint5498514074339311407
backgroundConnect24222126914255269
firstReactRender27253222832
getState17715825323187253
initialActions52102610
loadScripts820672136021310781360
setupStore1593582035
numNetworkReqs15110230580262305
WebpackStandard HomeuiStartup850737108664865993
load61656481652610768
domContentLoaded60855980248604751
domInteractive181285121647
firstPaint19559773174206608
backgroundConnect261361132757
firstReactRender30186583538
getState1161831315
initialActions4023358
loadScripts60455779046601739
setupStore1263041317
numNetworkReqs1367119870
WebpackPower User HomeuiStartup13631151203232018002032
load649571919115729919
domContentLoaded631560882105697882
domInteractive251382214782
firstPaint31094885250584885
backgroundConnect641021776170217
firstReactRender26242912729
getState14711016919158169
initialActions51328332
loadScripts627558871101687871
setupStore1262682526
numNetworkReqs1479928374265283
FirefoxBrowserifyStandard HomeuiStartup14941339180410215561704
load1270113314327113241411
domContentLoaded1269113314327113241410
domInteractive1243639657133237
firstPaint------
backgroundConnect4326115145068
firstReactRender26226252739
getState74233714
initialActions627610417
loadScripts1244111114046812921386
setupStore1376281328
numNetworkReqs1266515758
BrowserifyPower User HomeuiStartup24592111341936025633419
load13541157173517014681735
domContentLoaded13531157173517014671735
domInteractive19886561140318561
firstPaint------
backgroundConnect11236424101143424
firstReactRender38305584555
getState1278321133145211
initialActions914614946
loadScripts13151119169716714371697
setupStore3641865046186
numNetworkReqs1387032187221321
WebpackStandard HomeuiStartup16121374231314516781912
load13751178166510714411583
domContentLoaded13741177166510714411583
domInteractive1093036358121272
firstPaint------
backgroundConnect4725208245385
firstReactRender302377103042
getState8411412715
initialActions41717412
loadScripts13461156163010114031539
setupStore158199211334
numNetworkReqs1266715756
WebpackPower User HomeuiStartup24652209301424727063014
load14931276175814916331758
domContentLoaded14931276175814916321758
domInteractive1416438387208383
firstPaint------
backgroundConnect1003037686129376
firstReactRender393063114963
getState1327619637175196
initialActions15268192668
loadScripts14611254168414115961684
setupStore36101153341115
numNetworkReqs1345630477210304
📊 Page Load Benchmark Results

Current Commit: a25c11d | Date: 11/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 965ms (±46ms) 🟢 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 673ms (±60ms) 🟢 | historical mean value: 717ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 85ms (±121ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 965ms 46ms 942ms 1.35s 979ms 1.35s
domContentLoaded 673ms 60ms 652ms 1.23s 679ms 1.23s
firstPaint 85ms 121ms 60ms 1.28s 80ms 1.28s
firstContentfulPaint 85ms 121ms 60ms 1.28s 80ms 1.28s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 516 Bytes (0.01%)
  • ui: 8.44 KiB (0.12%)
  • common: 2.4 KiB (0.03%)

@khanti42 khanti42 added QA Passed and removed needs-qa Label will automate into QA workspace labels Nov 4, 2025
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset CO file change LGTM, very minimal changes on our side.

@metamaskbot
Copy link
Collaborator

Builds ready [7c3ba11]
UI Startup Metrics (1262 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1262109015699613211442
load107794213318911311235
domContentLoaded106990313219011251229
domInteractive221490131856
firstPaint57378132942710511220
backgroundConnect23521832914238253
firstReactRender25186072741
getState2175292441
initialActions71689718
loadScripts843671108990897999
setupStore1173041218
numNetworkReqs1367719670
BrowserifyPower User HomeuiStartup20221794271333022842713
load1024889139217212171392
domContentLoaded1009883134316012041343
domInteractive291587224587
firstPaint570168139844510101398
backgroundConnect24422132126259321
firstReactRender27243832838
getState17514620716194207
initialActions52174617
loadScripts78066010991509611099
setupStore17845112745
numNetworkReqs17896394111310394
WebpackStandard HomeuiStartup8257041138868311019
load59955588472593810
domContentLoaded59254886868587798
domInteractive161161101443
firstPaint18460866166195573
backgroundConnect261383152560
firstReactRender29186383336
getState1153131214
initialActions3116248
loadScripts58954585766585787
setupStore1152741217
numNetworkReqs1367319672
WebpackPower User HomeuiStartup13421131195326016231953
load676571983141794983
domContentLoaded653559950124759950
domInteractive271367215967
firstPaint26962764208404764
backgroundConnect611325577106255
firstReactRender27252912829
getState15110919921160199
initialActions21112311
loadScripts648557938120749938
setupStore1063071030
numNetworkReqs1459428470200284
FirefoxBrowserifyStandard HomeuiStartup14761280200713715301772
load1247110514639013031422
domContentLoaded1247110514629013021422
domInteractive1153431650125219
firstPaint------
backgroundConnect4526174234999
firstReactRender26235662739
getState84869716
initialActions6119620417
loadScripts1218108714358512701394
setupStore168204261336
numNetworkReqs1266516762
BrowserifyPower User HomeuiStartup25742185339935527713399
load14481195183421317481834
domContentLoaded14471194183321317471833
domInteractive25694637207488637
firstPaint------
backgroundConnect1154330384215303
firstReactRender473092195192
getState12810618420141184
initialActions1711253023125
loadScripts14011171176020016891760
setupStore40111263267126
numNetworkReqs17365357108272357
WebpackStandard HomeuiStartup16231451220814516551968
load13851217172410714291612
domContentLoaded13851216172310714291612
domInteractive983122136109180
firstPaint------
backgroundConnect52252193152115
firstReactRender312377123267
getState83568720
initialActions51487426
loadScripts1353118616369914131570
setupStore16797161570
numNetworkReqs1367118766
WebpackPower User HomeuiStartup27122427330024728803300
load16391462196915517821969
domContentLoaded16391461196815517821968
domInteractive18851603150350603
firstPaint------
backgroundConnect922823065173230
firstReactRender42325595355
getState1539625545188255
initialActions2011363226136
loadScripts16051430191514517261915
setupStore32998274798
numNetworkReqs1846834495256344
📊 Page Load Benchmark Results

Current Commit: 7c3ba11 | Date: 11/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.13s (±85ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 794ms (±80ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±15ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.13s 85ms 1.07s 1.49s 1.39s 1.49s
domContentLoaded 794ms 80ms 735ms 1.12s 1.05s 1.12s
firstPaint 84ms 15ms 64ms 212ms 96ms 212ms
firstContentfulPaint 84ms 15ms 64ms 212ms 96ms 212ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 75 Bytes (0%)
  • ui: 190 Bytes (0%)
  • common: 1.39 KiB (0.02%)

Copy link
Contributor

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [ec82bac]
UI Startup Metrics (1337 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13371171171110814171560
load1131924150110712001342
domContentLoaded1117916145110911961335
domInteractive2716105182476
firstPaint75588146345711651326
backgroundConnect26422438625270302
firstReactRender3219144173775
getState24768112745
initialActions816891124
loadScripts86668011951079361074
setupStore1375061428
numNetworkReqs1367620673
BrowserifyPower User HomeuiStartup21501823347147726163471
load1087918176325413991763
domContentLoaded1079911175025213891750
domInteractive291685214985
firstPaint6128614654489691465
backgroundConnect25323030618262306
firstReactRender29263533135
getState18916223120207231
initialActions52163516
loadScripts842683145923711501459
setupStore1492961329
numNetworkReqs15710031990306319
WebpackStandard HomeuiStartup8367151183838491023
load60656390269602774
domContentLoaded59955789066597762
domInteractive16127291436
firstPaint21757898223201768
backgroundConnect241272122656
firstReactRender29185383438
getState1153551217
initialActions40254417
loadScripts59555587964594751
setupStore1254051321
numNetworkReqs1367519869
WebpackPower User HomeuiStartup13821193204428516272044
load68658110861567531086
domContentLoaded663569993134701993
domInteractive261384214984
firstPaint31296999270578999
backgroundConnect50112025692202
firstReactRender27253122831
getState1518119325162193
initialActions91118284118
loadScripts658567982131690982
setupStore1162881128
numNetworkReqs1459427869197278
FirefoxBrowserifyStandard HomeuiStartup15261362195711415951744
load1296114415338413501460
domContentLoaded1296114315338413501460
domInteractive1263436052133236
firstPaint------
backgroundConnect4426136175075
firstReactRender27226682745
getState837110819
initialActions51838410
loadScripts1270112015058213221428
setupStore1384251322
numNetworkReqs1266715755
BrowserifyPower User HomeuiStartup23972073321530324413215
load13621172170417614621704
domContentLoaded13621172170417614621704
domInteractive21888651180264651
firstPaint------
backgroundConnect69242064879206
firstReactRender433185134885
getState1318718427152184
initialActions713391233
loadScripts13351151167217314181672
setupStore4161735371173
numNetworkReqs1526933592230335
WebpackStandard HomeuiStartup16011360231916116511946
load13641183169610514351578
domContentLoaded13641183169610514351577
domInteractive1013022936118177
firstPaint------
backgroundConnect50223213752117
firstReactRender29227283140
getState74476715
initialActions6118118312
loadScripts1334116416149614061523
setupStore167132181465
numNetworkReqs1366916763
WebpackPower User HomeuiStartup26052297299020028062990
load15771301187914916891879
domContentLoaded15761300187814916891878
domInteractive16159381111294381
firstPaint------
backgroundConnect10936430100126430
firstReactRender433192144892
getState1327824342158243
initialActions12283191583
loadScripts15361281182314316441823
setupStore4381053484105
numNetworkReqs1436228377205283
📊 Page Load Benchmark Results

Current Commit: ec82bac | Date: 11/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±64ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±62ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±38ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 64ms 1.03s 1.64s 1.09s 1.64s
domContentLoaded 737ms 62ms 707ms 1.30s 752ms 1.30s
firstPaint 86ms 38ms 60ms 464ms 92ms 464ms
firstContentfulPaint 86ms 38ms 60ms 464ms 92ms 464ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 75 Bytes (0%)
  • ui: 1.66 KiB (0.02%)
  • common: 1.39 KiB (0.02%)

Copy link
Contributor

@ameliejyc ameliejyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from core extension UX side. What is neNetwork though, is it meant to be newNetwork? I see it's in lots of places so out of the scope of this PR but just wondering.

@khanti42 khanti42 enabled auto-merge November 5, 2025 10:03
@khanti42 khanti42 added this pull request to the merge queue Nov 5, 2025
@github-project-automation github-project-automation bot moved this from Has approvals, needs CODEOWNER to Review finalised - Ready to be merged in PR review queue Nov 5, 2025
Merged via the queue into main with commit ed9dd94 Nov 5, 2025
173 checks passed
@khanti42 khanti42 deleted the feat/add-monad-network branch November 5, 2025 10:37
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Nov 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed release-13.9.0 Issue or pull request that will be included in release 13.9.0 size-M team-network-enablement

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants