feat: Remove legacy Ramps card and AssetListFundingModals components #37290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-design-system
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (5 files, +0 -77)
🔒 @MetaMask/extension-security-team (1 files, +0 -12)
💎 @MetaMask/metamask-assets (4 files, +0 -141)
👨🔧 @dbrans (1 files, +0 -12)
👨🔧 @HowardBraham (1 files, +0 -12)
|
7 tasks
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [97a437c]
UI Startup Metrics (1296 ± 94 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
georgewrmarshall
force-pushed
the
remove-ramps-card
branch
from
97a437c to
ad19ec7
Compare
Contributor
Author
There was a problem hiding this comment.
removing unused locales
Contributor
Author
There was a problem hiding this comment.
This component is no longer needed as we are using the BalanceEmptyState on the homepage
| store, | ||
| ); | ||
| }; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removing unit tests that check for RampsCard component in the asset list
| {showDetectedTokens && ( | ||
| <DetectedToken setShowDetectedTokens={setShowDetectedTokens} /> | ||
| )} | ||
| <AssetListFundingModals /> |
Contributor
Author
There was a problem hiding this comment.
Removing AssetListFundingModals which includes the RampsCard from the assets list
| } from '../../../selectors/transactions'; | ||
| import { getCurrentChainId } from '../../../../shared/modules/selectors/networks'; | ||
| import { | ||
| getCurrentNetwork, |
Contributor
Author
There was a problem hiding this comment.
Removing RampsCard from transactions list in favour of the BalanceEmptyState component
| @import 'notifications-settings-box'; | ||
| @import 'notifications-tag-counter'; | ||
| @import 'toast'; | ||
| @import "ramps-card"; |
Contributor
Author
There was a problem hiding this comment.
Removing deleted CSS file import
| > | ||
| Your activity | ||
| </h4> | ||
| <div |
Contributor
Author
There was a problem hiding this comment.
Updating snapshots
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [bb2eeb3]
UI Startup Metrics (1256 ± 74 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
georgewrmarshall
force-pushed
the
remove-ramps-card
branch
4 times, most recently
from
38e0064 to
cabd1d7
Compare
Comment on lines
-36
to
-47
| [ | ||
| "ui/components/app/assets/asset-list/asset-list-funding-modals/asset-list-funding-modals.tsx", | ||
| "ui/components/app/assets/asset-list/asset-list-funding-modals/index.ts", | ||
| "ui/components/app/assets/asset-list/asset-list.tsx", | ||
| "ui/components/app/assets/asset-list/index.ts", | ||
| "ui/components/multichain/account-overview/account-overview-eth.tsx", | ||
| "ui/components/multichain/account-overview/account-overview-layout.tsx", | ||
| "ui/components/multichain/account-overview/account-overview-tabs.tsx", | ||
| "ui/components/multichain/account-overview/account-overview.tsx", | ||
| "ui/components/multichain/account-overview/index.js", | ||
| "ui/components/multichain/index.js" | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
Updating development/circular-deps.jsonc to remove deleted files
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [cabd1d7]
UI Startup Metrics (1281 ± 91 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
georgewrmarshall
requested review from
a team,
HowardBraham and
dbrans
as code owners
Contributor
|
Can we also remove these images from |
georgewrmarshall
force-pushed
the
remove-ramps-card
branch
from
cabd1d7 to
dfc1328
Compare
Contributor
Author
Great catch @amandaye0h! Removed here dfc1328 |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [dfc1328]
UI Startup Metrics (1284 ± 94 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
HowardBraham
approved these changes
Nov 25, 2025
Contributor
HowardBraham
left a comment
HowardBraham
left a comment
There was a problem hiding this comment.
Approving just the circular dependency reduction
ameliejyc
approved these changes
Nov 25, 2025
wachunei
approved these changes
Nov 25, 2025
bergarces
approved these changes
Nov 25, 2025
metamaskbot
added
the
release-13.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the legacy Ramps card and AssetListFundingModals components as part of implementing the new BalanceEmptyState component. These legacy components provided funding options (buy/receive) when users had zero balance, but are now being replaced by a more integrated and streamlined BalanceEmptyState component.
Components Removed:
Key Changes:
AssetListFundingModalscomponent and related filesRampsCardcomponent, including tests, stories, and stylesBenefits:
This cleanup is essential preparation for the BalanceEmptyState implementation, which provides a more cohesive and user-friendly approach to handling empty wallet states.
Changelog
CHANGELOG entry: Removed legacy funding card components in preparation for improved empty state experience
Related issues
Part of BalanceEmptyState component implementation
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes legacy funding UI (RampsCard and AssetListFundingModals) and all references, tests, styles, circular-deps, and i18n strings tied to these components.
ui/components/multichain/ramps-card/*(component, index, styles, stories, tests).ui/components/app/assets/asset-list/asset-list-funding-modals/*and its test.asset-list.tsx,transaction-list.component.js, andunified-transaction-list.component.js(including zero-balance/ramps logic and imports).@import "ramps-card"frommultichain-components.scssand deleteramps-cardstyles.fundingMethod,tipsForUsingAWallet, andtipsForUsingAWalletDescriptionmessages across multiple localemessages.jsonfiles.development/circular-deps.jsonc.Written by Cursor Bugbot for commit dfc1328. This will update automatically on new commits. Configure here.