ci: count network requests made during benchmarks #37291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
added
the
no-changelog
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (2 files, +31 -11)
|
HowardBraham
changed the title
HowardBraham
force-pushed
the
count-http-requests
branch
from
2a31449 to
bbae151
Compare
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [bbae151]
UI Startup Metrics (1267 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
HowardBraham
force-pushed
the
count-http-requests
branch
from
bbae151 to
69dbd90
Compare
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [69dbd90]
UI Startup Metrics (1294 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
HowardBraham
force-pushed
the
count-http-requests
branch
from
69dbd90 to
2947abc
Compare
HowardBraham
force-pushed
the
count-http-requests
branch
from
2947abc to
a371c95
Compare
Collaborator
Builds ready [a371c95]
UI Startup Metrics (1274 ± 85 ms)
|
HowardBraham
force-pushed
the
count-http-requests
branch
from
a371c95 to
fe3a8ac
Compare
Collaborator
Builds ready [fe3a8ac]
UI Startup Metrics (1278 ± 83 ms)
|
HowardBraham
force-pushed
the
count-http-requests
branch
from
fe3a8ac to
b5a17bc
Compare
HowardBraham
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [a6a1235]
UI Startup Metrics (1380 ± 112 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Member
|
just a question: having the metrics in the PR comment seems that if there's a spike on number requests for example, people won't realize, because you have to unfold the comment, and also compare with previous numbers. Is there a plan to somehow add an alert in the future, if the numbers get super high all of a sudden? @HowardBraham 
|
Contributor
Author
@seaona This data is going to be posted to Sentry soon 🙂 |
MajorLift
reviewed
Oct 29, 2025
| jobs: | ||
| benchmarks: | ||
| if: ${{ github.event_name != 'merge_group' }} # Skip this job for the Merge Queue |
Contributor
Author
There was a problem hiding this comment.
Oh yeah, I noticed this as I was watching the workflows. There's absolutely no reason to run the benchmarks during the Merge Queue 🙂
javiergarciavera
approved these changes
Oct 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Measures and adds a
numNetworkReqsline to theUI Startup Metricstable. More detailed info on the network requests is coming in a later PR.Changelog
CHANGELOG entry: null
Related issues
Progresses: MetaMask/metamask-planning#6123
Note
Adds numNetworkReqs to page-load benchmarks by counting network requests via mocks and wiring through helpers, and skips certain CI jobs for merge queue runs.
numNetworkReqsto collectedMetrics; include inALL_METRICSused for stats output.test/e2e/mock-e2e.js,test/e2e/mock-e2e-pass-through.ts) and exposegetNetworkReport/clearNetworkReport.withFixtures) to benchmark runners; reset network counters per page load and record counts.numNetworkReqsand defineNetworkReport; renameALL_TRACEStoALL_METRICS; add browser-load start logging.publish-prereleaseandrun-benchmarksjobs onmerge_groupevents.Written by Cursor Bugbot for commit a6a1235. This will update automatically on new commits. Configure here.