-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: set auto focus false on confirmation alert modals #37294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set auto focus false on confirmation alert modals #37294
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d935ed0]
UI Startup Metrics (1189 ± 105 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5706cb4]
UI Startup Metrics (1263 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [202c9ff]
UI Startup Metrics (1252 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Set auto focus on confirmation alert modals to avoid highlighting clickable items automatically. Accessibility should still work when user press tab to navigate through the modal.
https://consensyssoftware.atlassian.net/browse/SUBS-681
Changelog
CHANGELOG entry: Set autofocus false on confirmation alert modals
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Disables auto focus in
AlertModalby addingautoFocus={false}to theModalcomponent.Written by Cursor Bugbot for commit 202c9ff. This will update automatically on new commits. Configure here.