Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Oct 28, 2025

Description

Set auto focus on confirmation alert modals to avoid highlighting clickable items automatically. Accessibility should still work when user press tab to navigate through the modal.

https://consensyssoftware.atlassian.net/browse/SUBS-681

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Set autofocus false on confirmation alert modals

Related issues

Fixes:

Manual testing steps

  1. Login to an account with shield subscription
  2. Use metamask test-dapp to do malicious transaction
  3. Click on shield coverage and check shield coverage modal
  4. There should be no auto focusing on any element inside the modal

Screenshots/Recordings

Before

Screenshot 2025-10-28 at 12 18 12 PM

After

Screenshot 2025-10-28 at 12 19 06 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Disables auto focus in AlertModal by adding autoFocus={false} to the Modal component.

Written by Cursor Bugbot for commit 202c9ff. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Oct 28, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: d935ed0 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±36ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 717ms (±34ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 36ms 1.01s 1.30s 1.05s 1.30s
domContentLoaded 717ms 34ms 695ms 979ms 735ms 979ms
firstPaint 76ms 11ms 60ms 164ms 88ms 164ms
firstContentfulPaint 76ms 11ms 60ms 164ms 88ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [d935ed0]
UI Startup Metrics (1189 ± 105 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup11891018176710512381346
load1015860152910110701181
domContentLoaded1009855152210110651173
domInteractive19135991743
firstPaint575140117839410131100
backgroundConnect1831692217187193
firstReactRender2916109113344
getState197107122038
initialActions60629717
loadScripts83368313371018901003
setupStore961821014
BrowserifyPower User HomeuiStartup22421877364156927943641
load1150914180433616051804
domContentLoaded1140907178932916011789
domInteractive36151603854160
firstPaint7528418064359691806
backgroundConnect25721854678251546
firstReactRender25233022730
getState20213326928213269
initialActions14268211768
loadScripts907690154430813431544
setupStore1382661326
WebpackStandard HomeuiStartup8437221140788531058
load63558696477637855
domContentLoaded62757994676632846
domInteractive15115281438
firstPaint19154949195191771
backgroundConnect23115672739
firstReactRender26165173134
getState1262441418
initialActions3014247
loadScripts62457793673630836
setupStore1052131115
WebpackPower User HomeuiStartup17731261250340423962503
load71560610301589341030
domContentLoaded690593978140900978
domInteractive181243102343
firstPaint500114986322919986
backgroundConnect11920531143273531
firstReactRender24223122531
getState19218123713197237
initialActions11042162942
loadScripts686591968136888968
setupStore22662202762
FirefoxBrowserifyStandard HomeuiStartup14551251187410315121591
load1246107816028512931371
domContentLoaded1246107816028512931371
domInteractive1153528142129207
firstPaint------
backgroundConnect4125274294469
firstReactRender25214552538
getState84465818
initialActions3029336
loadScripts1219105815807912711346
setupStore136191191218
BrowserifyPower User HomeuiStartup28762446375243229843752
load14371324166810915691668
domContentLoaded14361324166810915681668
domInteractive1578928054161280
firstPaint------
backgroundConnect21941540145325540
firstReactRender442988185188
getState1485122035167220
initialActions3303167714316
loadScripts13681229156710214691567
setupStore3151172840117
WebpackStandard HomeuiStartup16201433203211716491892
load1392124316899414471604
domContentLoaded1392124316899414471603
domInteractive1133240671116368
firstPaint------
backgroundConnect4821107176078
firstReactRender292281102940
getState74142713
initialActions4178838
loadScripts1361122116649214091573
setupStore146106131334
WebpackPower User HomeuiStartup29362324488568335564885
load15911295206725018662067
domContentLoaded15911295206625018662066
domInteractive1807832089285320
firstPaint------
backgroundConnect21326897310226897
firstReactRender45311172248117
getState17410929445196294
initialActions711451314
loadScripts15401271191421217451914
setupStore3152065129206
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 13 Bytes (0%)
  • common: 10 Bytes (0%)

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@lionellbriones lionellbriones added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@lionellbriones lionellbriones added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@lionellbriones lionellbriones added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@lionellbriones lionellbriones added this pull request to the merge queue Oct 28, 2025
@lionellbriones lionellbriones removed this pull request from the merge queue due to a manual request Oct 28, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 5706cb4 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±45ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±41ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 45ms 1.01s 1.40s 1.06s 1.40s
domContentLoaded 719ms 41ms 696ms 1.06s 735ms 1.06s
firstPaint 76ms 15ms 56ms 208ms 84ms 208ms
firstContentfulPaint 76ms 15ms 56ms 208ms 84ms 208ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [5706cb4]
UI Startup Metrics (1263 ± 92 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1263109914959213211442
load108695113178711391264
domContentLoaded107994713098611331249
domInteractive19136891841
firstPaint50782131441110591176
backgroundConnect2302172496235241
firstReactRender29197093346
getState19892102232
initialActions51536612
loadScripts8567161087869071020
setupStore962121014
BrowserifyPower User HomeuiStartup22801929335848930163358
load1163968175230516121752
domContentLoaded1155964174030216051740
domInteractive33161052656105
firstPaint753103176357410071763
backgroundConnect26822656281278562
firstReactRender25233232632
getState20915131834219318
initialActions152102266102
loadScripts911739147227813091472
setupStore1272551225
WebpackStandard HomeuiStartup8607341164888671112
load64759097687645928
domContentLoaded63958495286639918
domInteractive16115391443
firstPaint18758981199193603
backgroundConnect24136482836
firstReactRender27176083236
getState1262341420
initialActions3117347
loadScripts63658293983636905
setupStore1053741214
WebpackPower User HomeuiStartup18001483272439223402724
load72460411431658631143
domContentLoaded69059310251377611025
domInteractive201245103345
firstPaint5507610793067671079
backgroundConnect10325294100243294
firstReactRender25223442634
getState19316330931192309
initialActions12158192058
loadScripts68559010141337481014
setupStore21689213089
FirefoxBrowserifyStandard HomeuiStartup14391228194511214951620
load1229106715208812911391
domContentLoaded1228106615208812911391
domInteractive1123530743122208
firstPaint------
backgroundConnect4024139184667
firstReactRender25205262544
getState8413613713
initialActions31364311
loadScripts1203105014878512611371
setupStore1256571220
BrowserifyPower User HomeuiStartup28072386344232630863442
load14311245168211815441682
domContentLoaded14311244168211815431682
domInteractive1779542889248428
firstPaint------
backgroundConnect19536407130334407
firstReactRender392780124480
getState1648225448201254
initialActions2511443950144
loadScripts13771216161811414631618
setupStore3661223565122
WebpackStandard HomeuiStartup16481438208612117021900
load1409122017829114471597
domContentLoaded1409121917829114461597
domInteractive1123538453113219
firstPaint------
backgroundConnect4826167215581
firstReactRender3123152182978
getState104159171020
initialActions9118429348
loadScripts1379120017569014231561
setupStore1476681423
WebpackPower User HomeuiStartup29612277397849733423978
load16261387202520118102025
domContentLoaded16261387202420118092024
domInteractive15610425446190254
firstPaint------
backgroundConnect19534651201331651
firstReactRender54341181958118
getState18810328446221284
initialActions721841018
loadScripts15741359186917217741869
setupStore3561052747105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 13 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 202c9ff | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.11s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 777ms (±39ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 92ms (±15ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.11s 41ms 1.07s 1.39s 1.16s 1.39s
domContentLoaded 777ms 39ms 750ms 1.05s 811ms 1.05s
firstPaint 92ms 15ms 72ms 216ms 108ms 216ms
firstContentfulPaint 92ms 15ms 72ms 216ms 108ms 216ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [202c9ff]
UI Startup Metrics (1252 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1252112014377213091371
load107394812707111251196
domContentLoaded106594312667011201175
domInteractive18135071838
firstPaint61080121143010771158
backgroundConnect23221945423234246
firstReactRender271892103050
getState1984882236
initialActions606610620
loadScripts841716104070895951
setupStore1062531016
BrowserifyPower User HomeuiStartup22941891327246827133272
load1209975177529516401775
domContentLoaded1200967176229116241762
domInteractive47162666172266
firstPaint621180174047010061740
backgroundConnect295231821140281821
firstReactRender26233022730
getState20112125531217255
initialActions71287628
loadScripts948738149326112461493
setupStore1182841128
WebpackStandard HomeuiStartup8727341218799001038
load646590100372649807
domContentLoaded63958598271642798
domInteractive16124881443
firstPaint207581019199197631
backgroundConnect25126082941
firstReactRender28177893342
getState1363251623
initialActions3015257
loadScripts63558296969639788
setupStore1162641217
WebpackPower User HomeuiStartup18551570259133519632591
load72664310171207351017
domContentLoaded68162483264718832
domInteractive221349113549
firstPaint49566892296721892
backgroundConnect10132344102151344
firstReactRender27244452744
getState19211922121200221
initialActions2011644133164
loadScripts67662182160706821
setupStore20853153153
FirefoxBrowserifyStandard HomeuiStartup14951287187510715571694
load1276112115038513241427
domContentLoaded1276112115038513241427
domInteractive1203633149129218
firstPaint------
backgroundConnect4223251244866
firstReactRender26206882540
getState84829719
initialActions3128336
loadScripts1251110514768413021401
setupStore147140141336
BrowserifyPower User HomeuiStartup25392134320426327343204
load13701211157112715201571
domContentLoaded13691211157112715201571
domInteractive1749834277254342
firstPaint------
backgroundConnect14733341107270341
firstReactRender462981155181
getState1144616941153169
initialActions14186251286
loadScripts13341190152212014611522
setupStore23657184557
WebpackStandard HomeuiStartup16611478203210617151909
load1431122517349014811603
domContentLoaded1430122517349014801602
domInteractive1153441166122283
firstPaint------
backgroundConnect4725114165377
firstReactRender29227982938
getState845251013
initialActions51781047
loadScripts1401120217089014501571
setupStore1365661422
WebpackPower User HomeuiStartup31062511434764939464347
load17121405259532519692595
domContentLoaded17111405259432519682594
domInteractive18177958206206958
firstPaint------
backgroundConnect24751883304621883
firstReactRender46336095460
getState18410336763233367
initialActions14191251091
loadScripts16531367256730818512567
setupStore25685262885
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 13 Bytes (0%)
  • common: 10 Bytes (0%)

@lionellbriones lionellbriones added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 2ec5c04 Oct 28, 2025
174 checks passed
@lionellbriones lionellbriones deleted the feat/confirmation-alert-modal-autofocus-false branch October 28, 2025 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
@metamaskbot metamaskbot added the release-13.8.0 Issue or pull request that will be included in release 13.8.0 label Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.8.0 Issue or pull request that will be included in release 13.8.0 size-XS team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants