feat: show helptext and error when both are available #37297

lionellbriones · 2025-10-28T08:06:25Z

Description

On Claims form > Impacted transaction hash, if there is an error on the input, we are hiding the help text together with the Need help finding it? link. This PR keeps the link showing together with the error so users can still click it.

https://consensyssoftware.atlassian.net/browse/SUBS-675

Changelog

CHANGELOG entry: Show Need help link together with error on Claims form Transaction hash field

Related issues

Fixes:

Manual testing steps

Login/Create account with shield subscription
Go to Menu > Settings > Transaction Shield
Click on Submit a Claim
Try to input incorrect value on Impacted transaction hash. The error should be shown together with Need help link.

Screenshots/Recordings

Before

Help text was hidden when there is error

After

Show need help together with the error

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Keep the impacted transaction hash help link visible even when showing an error; minor help text styling tweak on chain ID field.

UI — Submit Claim Form (ui/pages/settings/transaction-shield-tab/submit-claim-form/submit-claim-form.tsx):
- Impacted Tx Hash field: When there's an error, render error text with inherited color and keep the help link visible via TextButton.
- Chain ID field: Remove explicit help text color from helpTextProps.

^{Written by Cursor Bugbot for commit b2dc0c2. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-28T08:06:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-28T08:33:27Z

📊 Page Load Benchmark Results

Current Commit: 03f2906 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±48ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 729ms (±43ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±14ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	48ms	1.01s	1.37s	1.09s	1.37s
domContentLoaded	729ms	43ms	697ms	1.03s	750ms	1.03s
firstPaint	79ms	14ms	60ms	200ms	88ms	200ms
firstContentfulPaint	79ms	14ms	60ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-28T08:33:32Z

Builds ready [03f2906]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 79 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1242	1108	1478	79	1298	1392
			load	1062	941	1316	77	1109	1221
			domContentLoaded	1057	937	1309	76	1103	1214
			domInteractive	19	13	77	8	17	38
			firstPaint	623	69	1316	437	1077	1196
			backgroundConnect	229	215	263	7	233	240
			firstReactRender	29	18	154	15	31	43
			getState	18	7	42	6	21	31
			initialActions	5	0	33	6	5	22
			loadScripts	833	714	1074	75	879	981
			setupStore	10	5	34	4	10	17
	Browserify	Power User Home	uiStartup	2397	1950	3810	644	3271	3810
			load	1205	965	1850	328	1646	1850
			domContentLoaded	1197	959	1845	324	1639	1845
			domInteractive	44	15	253	56	53	253
			firstPaint	553	108	1849	464	984	1849
			backgroundConnect	259	227	429	49	279	429
			firstReactRender	28	24	50	6	28	50
			getState	217	178	303	25	220	303
			initialActions	8	2	29	8	8	29
			loadScripts	956	733	1563	304	1373	1563
			setupStore	17	8	31	8	28	31
	Webpack	Standard Home	uiStartup	861	737	1158	79	879	1037
			load	655	591	955	83	655	862
			domContentLoaded	647	584	934	82	649	854
			domInteractive	16	11	48	8	14	41
			firstPaint	208	59	953	212	201	725
			backgroundConnect	23	12	51	7	27	39
			firstReactRender	26	17	44	7	32	35
			getState	12	6	24	4	14	19
			initialActions	3	1	18	3	4	8
			loadScripts	643	582	923	80	646	852
			setupStore	10	5	22	3	12	14
	Webpack	Power User Home	uiStartup	1773	1328	2919	437	1898	2919
			load	762	616	1489	237	825	1489
			domContentLoaded	720	604	1336	197	721	1336
			domInteractive	20	13	43	11	34	43
			firstPaint	350	67	1094	310	633	1094
			backgroundConnect	107	12	356	117	182	356
			firstReactRender	25	21	37	3	25	37
			getState	181	111	239	32	198	239
			initialActions	5	0	48	12	2	48
			loadScripts	715	602	1324	194	711	1324
			setupStore	19	6	101	25	11	101
Firefox	Browserify	Standard Home	uiStartup	1489	1245	1963	124	1546	1672
			load	1272	1078	1682	95	1333	1434
			domContentLoaded	1272	1078	1681	95	1333	1433
			domInteractive	128	37	428	61	133	258
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	24	160	19	48	84
			firstReactRender	26	21	55	7	26	47
			getState	8	4	67	8	8	14
			initialActions	3	1	11	1	3	5
			loadScripts	1245	1058	1593	89	1300	1407
			setupStore	11	6	35	4	12	16
	Browserify	Power User Home	uiStartup	2956	2363	4426	647	3822	4426
			load	1487	1273	2181	212	1558	2181
			domContentLoaded	1487	1273	2180	212	1558	2180
			domInteractive	184	98	317	68	248	317
			firstPaint	-	-	-	-	-	-
			backgroundConnect	242	40	1160	314	581	1160
			firstReactRender	43	32	56	8	49	56
			getState	175	120	232	33	211	232
			initialActions	16	1	68	21	28	68
			loadScripts	1437	1240	2013	182	1473	2013
			setupStore	30	5	127	35	60	127
	Webpack	Standard Home	uiStartup	1576	1376	1999	127	1631	1844
			load	1348	1190	1674	101	1413	1577
			domContentLoaded	1348	1189	1674	101	1413	1577
			domInteractive	107	32	514	68	114	265
			firstPaint	-	-	-	-	-	-
			backgroundConnect	41	20	104	16	47	71
			firstReactRender	28	22	75	10	28	41
			getState	10	4	156	19	9	13
			initialActions	6	1	138	16	3	24
			loadScripts	1323	1173	1649	98	1383	1546
			setupStore	15	6	92	13	14	35
	Webpack	Power User Home	uiStartup	2932	2307	4233	634	3752	4233
			load	1567	1217	2032	250	1845	2032
			domContentLoaded	1566	1217	2031	250	1844	2031
			domInteractive	161	70	372	91	203	372
			firstPaint	-	-	-	-	-	-
			backgroundConnect	298	28	1045	379	825	1045
			firstReactRender	42	30	68	10	48	68
			getState	180	82	340	58	223	340
			initialActions	9	1	33	9	17	33
			loadScripts	1492	1199	1867	196	1698	1867
			setupStore	23	5	96	22	29	96

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 398 Bytes (0.01%)
common: 10 Bytes (0%)

metamaskbot · 2025-10-28T17:10:10Z

📊 Page Load Benchmark Results

Current Commit: b182ef4 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 727ms (±39ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±15ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.02s	1.36s	1.07s	1.36s
domContentLoaded	727ms	39ms	708ms	1.02s	746ms	1.02s
firstPaint	79ms	15ms	60ms	220ms	88ms	220ms
firstContentfulPaint	79ms	15ms	60ms	220ms	88ms	220ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-28T17:10:15Z

Builds ready [b182ef4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1299 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1299	1134	1573	90	1358	1476
			load	1116	960	1332	88	1176	1279
			domContentLoaded	1109	957	1326	87	1172	1274
			domInteractive	21	14	78	11	20	46
			firstPaint	710	165	1339	447	1135	1229
			backgroundConnect	233	221	264	8	237	247
			firstReactRender	28	20	53	8	33	43
			getState	21	7	104	11	24	35
			initialActions	5	0	51	7	6	11
			loadScripts	883	736	1090	87	942	1046
			setupStore	10	7	26	3	10	13
	Browserify	Power User Home	uiStartup	2020	1743	2977	377	2509	2977
			load	1040	856	1526	255	1433	1526
			domContentLoaded	1031	849	1519	252	1422	1519
			domInteractive	30	14	86	21	51	86
			firstPaint	680	154	1473	422	950	1473
			backgroundConnect	243	175	875	169	205	875
			firstReactRender	23	20	30	2	24	30
			getState	181	114	232	33	199	232
			initialActions	8	2	44	10	8	44
			loadScripts	839	673	1261	222	1195	1261
			setupStore	16	8	27	7	25	27
	Webpack	Standard Home	uiStartup	874	750	1170	77	887	1077
			load	652	600	993	71	657	868
			domContentLoaded	644	594	973	70	652	862
			domInteractive	17	12	56	10	15	46
			firstPaint	202	60	999	201	199	639
			backgroundConnect	24	13	38	6	30	36
			firstReactRender	27	17	58	8	33	36
			getState	12	6	28	4	14	17
			initialActions	4	1	16	3	5	14
			loadScripts	641	592	962	68	649	849
			setupStore	11	5	27	4	13	16
	Webpack	Power User Home	uiStartup	1828	1559	2535	327	1988	2535
			load	778	644	1410	210	1003	1410
			domContentLoaded	742	627	1285	180	900	1285
			domInteractive	21	13	44	11	37	44
			firstPaint	460	63	1288	371	671	1288
			backgroundConnect	120	22	443	122	220	443
			firstReactRender	26	23	32	2	27	32
			getState	181	75	204	32	198	204
			initialActions	7	1	45	13	8	45
			loadScripts	736	625	1274	176	887	1274
			setupStore	14	7	48	11	15	48
Firefox	Browserify	Standard Home	uiStartup	1442	1222	1879	108	1510	1640
			load	1227	1057	1461	75	1270	1365
			domContentLoaded	1227	1056	1461	75	1270	1365
			domInteractive	113	33	307	43	127	204
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	24	211	25	47	80
			firstReactRender	25	21	55	5	25	35
			getState	7	4	26	4	10	13
			initialActions	3	1	12	1	3	5
			loadScripts	1202	1040	1429	72	1244	1328
			setupStore	11	5	52	5	12	16
	Browserify	Power User Home	uiStartup	2743	2332	3753	413	2951	3753
			load	1394	1239	1567	98	1483	1567
			domContentLoaded	1394	1239	1567	98	1483	1567
			domInteractive	156	90	275	61	248	275
			firstPaint	-	-	-	-	-	-
			backgroundConnect	187	36	481	147	326	481
			firstReactRender	39	30	51	7	46	51
			getState	152	49	209	36	184	209
			initialActions	19	1	158	39	10	158
			loadScripts	1348	1214	1540	96	1437	1540
			setupStore	24	5	90	24	43	90
	Webpack	Standard Home	uiStartup	1687	1508	2321	128	1728	1998
			load	1439	1259	1768	103	1486	1699
			domContentLoaded	1439	1259	1768	103	1486	1698
			domInteractive	113	36	415	71	115	251
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	26	181	23	59	81
			firstReactRender	31	25	82	9	31	43
			getState	10	4	181	18	9	16
			initialActions	4	2	17	2	4	8
			loadScripts	1408	1238	1742	97	1452	1629
			setupStore	14	8	116	11	15	19
	Webpack	Power User Home	uiStartup	2955	2473	4607	607	3059	4607
			load	1609	1396	2163	234	1787	2163
			domContentLoaded	1609	1396	2163	235	1787	2163
			domInteractive	140	71	268	53	174	268
			firstPaint	-	-	-	-	-	-
			backgroundConnect	249	38	971	308	320	971
			firstReactRender	41	29	54	7	46	54
			getState	169	89	233	47	210	233
			initialActions	19	1	113	27	27	113
			loadScripts	1538	1360	1947	187	1677	1947
			setupStore	61	8	459	106	74	459

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 245 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-10-28T18:26:05Z

📊 Page Load Benchmark Results

Current Commit: 3fb2405 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±45ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 712ms (±39ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	45ms	1.00s	1.36s	1.05s	1.36s
domContentLoaded	712ms	39ms	696ms	999ms	724ms	999ms
firstPaint	75ms	13ms	56ms	192ms	84ms	192ms
firstContentfulPaint	75ms	13ms	56ms	192ms	84ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-28T18:26:11Z

Builds ready [3fb2405]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1274 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1274	1117	1515	94	1334	1426
			load	1096	945	1347	93	1159	1249
			domContentLoaded	1089	940	1337	92	1153	1241
			domInteractive	19	14	100	11	18	44
			firstPaint	581	91	1343	445	1115	1246
			backgroundConnect	231	217	272	8	233	240
			firstReactRender	28	18	50	7	34	44
			getState	18	7	36	6	20	30
			initialActions	6	1	70	8	6	17
			loadScripts	865	724	1110	92	925	1023
			setupStore	9	6	22	2	10	14
	Browserify	Power User Home	uiStartup	2332	1934	3336	532	3184	3336
			load	1195	978	1832	322	1694	1832
			domContentLoaded	1185	971	1815	317	1645	1815
			domInteractive	32	15	80	24	67	80
			firstPaint	817	175	1772	497	1030	1772
			backgroundConnect	296	233	632	107	300	632
			firstReactRender	26	23	33	3	28	33
			getState	208	164	260	21	219	260
			initialActions	13	3	113	27	6	113
			loadScripts	928	738	1475	277	1351	1475
			setupStore	12	8	26	4	12	26
	Webpack	Standard Home	uiStartup	858	726	1159	83	873	1055
			load	639	584	961	71	645	789
			domContentLoaded	632	578	954	71	639	781
			domInteractive	15	12	52	8	15	38
			firstPaint	190	59	949	182	173	610
			backgroundConnect	25	13	84	9	29	37
			firstReactRender	27	17	55	8	32	37
			getState	12	5	26	4	15	22
			initialActions	3	1	14	2	4	7
			loadScripts	629	576	942	69	637	770
			setupStore	10	5	32	3	11	14
	Webpack	Power User Home	uiStartup	1799	1334	2552	332	1846	2552
			load	754	629	1139	156	836	1139
			domContentLoaded	711	615	977	119	808	977
			domInteractive	23	13	53	12	35	53
			firstPaint	517	78	1047	292	660	1047
			backgroundConnect	116	38	332	103	119	332
			firstReactRender	26	23	43	5	25	43
			getState	198	121	285	33	205	285
			initialActions	13	1	58	16	21	58
			loadScripts	706	612	967	115	795	967
			setupStore	25	6	78	23	37	78
Firefox	Browserify	Standard Home	uiStartup	1470	1270	1875	107	1516	1681
			load	1253	1098	1491	87	1300	1403
			domContentLoaded	1252	1098	1491	87	1300	1403
			domInteractive	117	36	392	53	123	228
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	24	134	19	49	92
			firstReactRender	26	21	55	7	25	46
			getState	9	4	74	11	7	31
			initialActions	3	1	44	4	3	5
			loadScripts	1225	1082	1427	84	1274	1378
			setupStore	12	5	31	4	13	19
	Browserify	Power User Home	uiStartup	2823	2375	3903	431	3123	3903
			load	1428	1252	1821	134	1492	1821
			domContentLoaded	1428	1252	1820	134	1492	1820
			domInteractive	167	71	341	76	225	341
			firstPaint	-	-	-	-	-	-
			backgroundConnect	219	37	678	202	422	678
			firstReactRender	45	31	84	13	51	84
			getState	160	97	327	51	163	327
			initialActions	10	1	44	13	15	44
			loadScripts	1366	1198	1759	132	1427	1759
			setupStore	47	6	142	44	87	142
	Webpack	Standard Home	uiStartup	1640	1424	2066	130	1675	1974
			load	1399	1212	1700	93	1444	1598
			domContentLoaded	1398	1211	1699	93	1444	1597
			domInteractive	113	30	429	69	114	339
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	21	159	26	65	118
			firstReactRender	29	23	77	10	29	43
			getState	8	4	146	14	8	13
			initialActions	4	1	59	7	3	12
			loadScripts	1365	1195	1675	90	1409	1533
			setupStore	17	7	178	23	14	51
	Webpack	Power User Home	uiStartup	3005	2568	4170	443	3267	4170
			load	1640	1398	2217	221	1741	2217
			domContentLoaded	1639	1397	2217	222	1740	2217
			domInteractive	145	83	244	49	195	244
			firstPaint	-	-	-	-	-	-
			backgroundConnect	222	56	705	181	318	705
			firstReactRender	41	31	52	8	50	52
			getState	181	74	417	74	208	417
			initialActions	12	2	50	14	15	50
			loadScripts	1572	1357	2153	198	1705	2153
			setupStore	45	6	167	44	61	167

metamaskbot · 2025-10-29T08:35:55Z

📊 Page Load Benchmark Results

Current Commit: b2dc0c2 | Date: 10/29/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±54ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 721ms (±63ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 87ms (±128ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	54ms	1.01s	1.50s	1.06s	1.50s
domContentLoaded	721ms	63ms	701ms	1.29s	738ms	1.29s
firstPaint	87ms	128ms	60ms	1.36s	84ms	1.36s
firstContentfulPaint	87ms	128ms	60ms	1.36s	84ms	1.36s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-29T08:36:05Z

Builds ready [b2dc0c2]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1284 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1284	1125	1464	81	1333	1430
			load	1101	954	1300	79	1150	1224
			domContentLoaded	1096	951	1286	78	1144	1218
			domInteractive	20	14	52	9	20	47
			firstPaint	660	79	1298	460	1131	1234
			backgroundConnect	233	218	275	8	235	249
			firstReactRender	27	17	49	7	30	40
			getState	19	8	43	6	22	31
			initialActions	5	1	19	3	6	12
			loadScripts	869	732	1058	77	916	990
			setupStore	10	5	22	3	10	14
	Browserify	Power User Home	uiStartup	2255	1783	3524	659	3287	3524
			load	1185	948	1994	361	1654	1994
			domContentLoaded	1171	940	1971	353	1632	1971
			domInteractive	30	15	90	23	57	90
			firstPaint	741	153	2002	556	996	2002
			backgroundConnect	261	227	369	47	298	369
			firstReactRender	25	23	33	3	26	33
			getState	183	161	244	25	191	244
			initialActions	9	2	71	16	7	71
			loadScripts	925	711	1623	316	1355	1623
			setupStore	11	8	30	5	11	30
	Webpack	Standard Home	uiStartup	898	759	1207	86	915	1112
			load	667	604	1019	80	665	884
			domContentLoaded	659	597	1004	79	657	870
			domInteractive	16	12	73	9	15	33
			firstPaint	194	62	964	193	205	628
			backgroundConnect	25	13	47	7	30	39
			firstReactRender	29	18	93	10	35	38
			getState	12	5	22	4	15	18
			initialActions	3	1	9	2	5	8
			loadScripts	656	594	993	77	655	858
			setupStore	11	6	21	3	13	16
	Webpack	Power User Home	uiStartup	1743	1393	2409	347	2242	2409
			load	734	630	987	131	898	987
			domContentLoaded	693	608	907	99	801	907
			domInteractive	22	13	70	15	35	70
			firstPaint	465	85	952	310	804	952
			backgroundConnect	145	23	475	171	397	475
			firstReactRender	26	22	35	3	26	35
			getState	162	149	207	16	166	207
			initialActions	8	1	35	11	15	35
			loadScripts	689	606	896	96	790	896
			setupStore	22	6	89	21	29	89
Firefox	Browserify	Standard Home	uiStartup	1502	1349	1788	86	1559	1670
			load	1280	1143	1548	72	1330	1386
			domContentLoaded	1280	1142	1548	72	1330	1386
			domInteractive	122	33	368	55	126	235
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	26	148	20	48	87
			firstReactRender	26	21	74	7	26	36
			getState	9	4	76	9	9	16
			initialActions	5	2	192	19	4	6
			loadScripts	1253	1124	1524	70	1298	1361
			setupStore	12	9	35	3	13	17
	Browserify	Power User Home	uiStartup	2758	2224	4307	618	3168	4307
			load	1420	1226	1863	186	1575	1863
			domContentLoaded	1420	1226	1863	186	1575	1863
			domInteractive	175	107	347	77	265	347
			firstPaint	-	-	-	-	-	-
			backgroundConnect	195	31	638	192	437	638
			firstReactRender	39	29	79	12	42	79
			getState	139	100	199	28	151	199
			initialActions	26	1	278	66	18	278
			loadScripts	1371	1186	1809	174	1518	1809
			setupStore	30	6	106	32	36	106
	Webpack	Standard Home	uiStartup	1554	1431	2215	127	1566	1801
			load	1326	1221	1564	76	1361	1533
			domContentLoaded	1325	1221	1563	76	1361	1532
			domInteractive	104	32	398	58	101	222
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	231	25	48	75
			firstReactRender	27	20	73	8	28	38
			getState	12	4	164	22	10	56
			initialActions	4	1	66	8	3	6
			loadScripts	1299	1204	1540	72	1334	1486
			setupStore	13	6	87	11	12	27
	Webpack	Power User Home	uiStartup	2759	2202	3747	458	3142	3747
			load	1566	1229	2142	258	1806	2142
			domContentLoaded	1565	1228	2142	258	1805	2142
			domInteractive	160	80	380	92	203	380
			firstPaint	-	-	-	-	-	-
			backgroundConnect	190	30	821	249	438	821
			firstReactRender	47	31	83	14	56	83
			getState	147	64	364	69	188	364
			initialActions	7	1	24	6	13	24
			loadScripts	1512	1210	1950	214	1682	1950
			setupStore	21	6	69	17	38	69

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 245 Bytes (0%)
common: 10 Bytes (0%)

feat: show helptext and error when both are available

03f2906

metamaskbot added the team-onboarding Onboarding team label Oct 28, 2025

github-actions bot added the size-S label Oct 28, 2025

lionellbriones added 2 commits October 29, 2025 00:06

Merge branch 'main' into feat/show-both-help-text-and-error

fefccea

feat: show need help together with error

81b4dd2

lionellbriones marked this pull request as ready for review October 28, 2025 16:38

Merge branch 'main' into feat/show-both-help-text-and-error

2aabfe2

This comment was marked as outdated.

Sign in to view

feat: put back data-test id

b182ef4

lionellbriones requested a review from tuna1207 October 28, 2025 16:41

This comment was marked as outdated.

Sign in to view

lionellbriones requested a review from chaitanyapotti October 28, 2025 16:45

Merge branch 'main' into feat/show-both-help-text-and-error

3fb2405

tuna1207 approved these changes Oct 29, 2025

View reviewed changes

chaitanyapotti approved these changes Oct 29, 2025

View reviewed changes

chaitanyapotti added this pull request to the merge queue Oct 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2025

lionellbriones added this pull request to the merge queue Oct 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2025

Merge branch 'main' into feat/show-both-help-text-and-error

b2dc0c2

lionellbriones added this pull request to the merge queue Oct 29, 2025

Merged via the queue into main with commit d56f9dd Oct 29, 2025
328 of 331 checks passed

lionellbriones deleted the feat/show-both-help-text-and-error branch October 29, 2025 10:50

github-actions bot locked and limited conversation to collaborators Oct 29, 2025

metamaskbot added the release-13.8.0 Issue or pull request that will be included in release 13.8.0 label Oct 29, 2025

feat: show helptext and error when both are available #37297

feat: show helptext and error when both are available #37297

Conversation

lionellbriones commented Oct 28, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 28, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 28, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 28, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 28, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 28, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Oct 29, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lionellbriones commented Oct 28, 2025 •

edited by cursor bot

Loading