feat: remove errors showing on UI

[lionellbriones]

Description

Fix error showing on UI on Shield plan page

Changelog

CHANGELOG entry: N/A

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Removes error handling and on-screen error messages from the Shield Plan page while keeping loading and pricing logic intact.

• UI – ui/pages/shield-plan/shield-plan.tsx:
  • Remove error handling: stop destructuring error from useUserSubscriptions and useSubscriptionPricing, and delete the combined error variable.
  • Remove on-screen error message rendering; retain loading state and pricing/subscription logic.

^{Written by Cursor Bugbot for commit 2694f76. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

📊 Page Load Benchmark Results

Current Commit: fae877d | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.06s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
• domContentLoaded-> current mean value: 734ms (±35ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	42ms	1.02s	1.32s	1.10s	1.32s
domContentLoaded	734ms	35ms	705ms	985ms	760ms	985ms
firstPaint	79ms	13ms	64ms	192ms	88ms	192ms
firstContentfulPaint	79ms	13ms	64ms	192ms	88ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

---

Results generated automatically by MetaMask CI

[metamaskbot]

Builds ready [fae877d]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1259 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1259	1124	1604	86	1306	1406
			load	1079	945	1440	86	1129	1218
			domContentLoaded	1074	942	1435	85	1121	1211
			domInteractive	20	13	79	11	18	50
			firstPaint	566	92	1270	431	1079	1175
			backgroundConnect	232	220	259	7	236	251
			firstReactRender	26	17	46	6	30	38
			getState	18	8	35	6	22	30
			initialActions	4	1	17	3	5	12
			loadScripts	847	722	1211	85	892	985
			setupStore	10	6	24	3	10	17
	Browserify	Power User Home	uiStartup	2407	1908	4343	772	3396	4343
			load	1185	950	1966	334	1619	1966
			domContentLoaded	1175	942	1955	329	1614	1955
			domInteractive	30	15	78	22	57	78
			firstPaint	795	248	1960	530	1020	1960
			backgroundConnect	290	226	908	162	271	908
			firstReactRender	25	23	29	2	26	29
			getState	218	155	381	46	212	381
			initialActions	18	3	115	35	6	115
			loadScripts	921	715	1482	282	1347	1482
			setupStore	11	9	18	3	11	18
	Webpack	Standard Home	uiStartup	874	743	1491	94	886	1061
			load	652	595	1307	90	655	817
			domContentLoaded	644	589	1299	89	649	810
			domInteractive	16	12	55	8	15	42
			firstPaint	197	59	900	197	196	665
			backgroundConnect	25	12	48	7	28	38
			firstReactRender	28	17	85	10	33	37
			getState	12	6	28	4	14	20
			initialActions	3	0	14	2	4	8
			loadScripts	640	587	1285	87	647	799
			setupStore	10	5	23	3	12	16
	Webpack	Power User Home	uiStartup	1860	1551	2627	364	2345	2627
			load	732	624	1069	145	866	1069
			domContentLoaded	704	608	1021	128	823	1021
			domInteractive	24	13	123	26	22	123
			firstPaint	501	78	1027	337	836	1027
			backgroundConnect	115	20	386	116	270	386
			firstReactRender	27	24	42	4	27	42
			getState	196	186	234	12	200	234
			initialActions	12	1	47	15	19	47
			loadScripts	700	606	1011	124	811	1011
			setupStore	27	8	96	24	36	96
Firefox	Browserify	Standard Home	uiStartup	1464	1280	1915	118	1512	1702
			load	1246	1107	1557	82	1292	1399
			domContentLoaded	1246	1107	1557	82	1292	1399
			domInteractive	116	31	278	42	125	210
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	24	153	26	49	118
			firstReactRender	25	21	54	5	26	38
			getState	7	3	43	4	7	12
			initialActions	3	1	13	2	3	5
			loadScripts	1218	1089	1455	76	1260	1359
			setupStore	13	6	238	23	12	16
	Browserify	Power User Home	uiStartup	2807	2322	5187	708	3070	5187
			load	1400	1162	1709	140	1482	1709
			domContentLoaded	1400	1162	1709	140	1481	1709
			domInteractive	179	94	429	102	266	429
			firstPaint	-	-	-	-	-	-
			backgroundConnect	245	29	1534	370	393	1534
			firstReactRender	38	30	58	8	45	58
			getState	164	82	243	40	197	243
			initialActions	16	1	105	26	15	105
			loadScripts	1352	1138	1665	136	1446	1665
			setupStore	24	5	100	28	23	100
	Webpack	Standard Home	uiStartup	1583	1372	2193	141	1653	1880
			load	1350	1193	1735	105	1392	1607
			domContentLoaded	1350	1193	1735	105	1392	1606
			domInteractive	104	35	355	48	109	224
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	22	162	19	49	73
			firstReactRender	28	22	59	6	29	38
			getState	10	4	167	17	10	24
			initialActions	6	1	217	22	4	15
			loadScripts	1324	1172	1703	102	1370	1569
			setupStore	17	7	177	21	14	52
	Webpack	Power User Home	uiStartup	2947	2474	4540	623	3461	4540
			load	1594	1330	2286	275	1875	2286
			domContentLoaded	1594	1330	2285	275	1874	2285
			domInteractive	153	75	372	74	187	372
			firstPaint	-	-	-	-	-	-
			backgroundConnect	199	34	799	248	450	799
			firstReactRender	50	31	101	16	56	101
			getState	180	120	261	39	202	261
			initialActions	7	1	21	6	11	21
			loadScripts	1540	1264	2146	248	1799	2146
			setupStore	37	6	127	41	61	127

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: -117 Bytes (0%)
• common: 10 Bytes (0%)

[metamaskbot]

📊 Page Load Benchmark Results

Current Commit: 2694f76 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.03s (±44ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 720ms (±39ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	44ms	1.01s	1.35s	1.06s	1.35s
domContentLoaded	720ms	39ms	698ms	987ms	741ms	987ms
firstPaint	76ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	76ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

---

Results generated automatically by MetaMask CI

[metamaskbot]

Builds ready [2694f76]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1249 ± 76 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1249	1103	1446	76	1294	1382
			load	1071	939	1263	74	1112	1199
			domContentLoaded	1065	934	1253	74	1107	1192
			domInteractive	20	13	57	9	19	44
			firstPaint	620	73	1184	426	1079	1152
			backgroundConnect	230	219	260	7	233	242
			firstReactRender	27	18	43	6	30	38
			getState	19	7	90	9	21	30
			initialActions	5	0	44	5	5	16
			loadScripts	841	718	1033	73	887	968
			setupStore	9	6	23	2	10	13
	Browserify	Power User Home	uiStartup	2119	1729	3850	616	2713	3850
			load	1070	851	1871	328	1453	1871
			domContentLoaded	1059	845	1851	320	1440	1851
			domInteractive	28	14	67	17	47	67
			firstPaint	713	143	1884	508	915	1884
			backgroundConnect	270	174	1009	206	301	1009
			firstReactRender	27	22	70	11	26	70
			getState	185	136	216	19	194	216
			initialActions	5	3	17	3	5	17
			loadScripts	846	676	1374	253	1177	1374
			setupStore	13	8	27	7	14	27
	Webpack	Standard Home	uiStartup	856	730	1081	71	867	1051
			load	638	586	885	63	649	847
			domContentLoaded	631	579	878	62	642	840
			domInteractive	16	11	74	10	14	38
			firstPaint	182	58	881	173	190	606
			backgroundConnect	24	13	54	8	29	43
			firstReactRender	27	17	50	8	32	36
			getState	12	6	38	4	14	16
			initialActions	3	0	14	3	4	7
			loadScripts	627	577	868	60	640	830
			setupStore	10	5	19	3	12	15
	Webpack	Power User Home	uiStartup	1742	1486	2405	295	1749	2405
			load	719	609	1118	149	829	1118
			domContentLoaded	686	594	943	117	774	943
			domInteractive	19	12	44	10	32	44
			firstPaint	478	67	947	318	778	947
			backgroundConnect	94	18	294	91	89	294
			firstReactRender	25	22	30	2	27	30
			getState	180	93	204	25	191	204
			initialActions	15	0	97	25	27	97
			loadScripts	681	591	933	113	764	933
			setupStore	19	6	59	15	27	59
Firefox	Browserify	Standard Home	uiStartup	1516	1313	2045	133	1576	1805
			load	1285	1130	1577	91	1345	1450
			domContentLoaded	1284	1130	1577	91	1345	1450
			domInteractive	123	36	429	53	137	203
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	25	209	31	50	118
			firstReactRender	26	21	52	6	27	41
			getState	9	5	199	19	9	13
			initialActions	3	1	13	2	3	8
			loadScripts	1255	1108	1551	87	1316	1407
			setupStore	17	8	218	29	13	22
	Browserify	Power User Home	uiStartup	2846	2401	3712	451	3472	3712
			load	1423	1241	1678	146	1627	1678
			domContentLoaded	1423	1241	1678	146	1626	1678
			domInteractive	173	64	415	82	224	415
			firstPaint	-	-	-	-	-	-
			backgroundConnect	209	38	717	198	428	717
			firstReactRender	42	29	81	12	47	81
			getState	171	104	227	30	193	227
			initialActions	14	1	77	24	10	77
			loadScripts	1370	1202	1597	125	1448	1597
			setupStore	25	6	98	25	34	98
	Webpack	Standard Home	uiStartup	1691	1493	2425	125	1732	1867
			load	1449	1268	1848	99	1487	1625
			domContentLoaded	1448	1268	1848	99	1486	1625
			domInteractive	111	30	390	53	120	207
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	25	208	24	61	81
			firstReactRender	30	23	83	10	29	42
			getState	9	4	141	14	9	15
			initialActions	5	1	202	20	4	7
			loadScripts	1416	1251	1751	94	1454	1594
			setupStore	13	7	43	4	14	19
	Webpack	Power User Home	uiStartup	2960	2440	3943	422	3388	3943
			load	1605	1364	1853	149	1753	1853
			domContentLoaded	1605	1363	1852	149	1753	1852
			domInteractive	135	76	243	52	183	243
			firstPaint	-	-	-	-	-	-
			backgroundConnect	230	51	648	199	382	648
			firstReactRender	45	31	70	11	52	70
			getState	186	104	313	53	228	313
			initialActions	13	1	107	25	12	107
			loadScripts	1538	1326	1796	140	1689	1796
			setupStore	30	5	74	21	43	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: -116 Bytes (0%)
• common: 10 Bytes (0%)