fix: flaky test Token List..., Token Details, Send ERC20because they broke with error can't convert undefined to object
#37302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +7 -0)
|
seaona
added
flaky tests
no-changelog
Gudahtt
reviewed
Oct 28, 2025
jvbriones
approved these changes
Oct 28, 2025
Member
|
I wonder what the root cause of the failure is. Most initialization steps should be completed by the time the UI loads, I'm not aware of anything else in the background that would be possible to call "too early" |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [3121209]
UI Startup Metrics (1309 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jvbriones
previously approved these changes
Oct 28, 2025
hjetpoluru
previously approved these changes
Oct 28, 2025
Member
Author
I'm not sure neither 🤔 Is it possible that changes on the multichain work have caused this? ie if the multichain asset list is not yet 'created', trying to Import a token might break the wallet, if we try to access it? This is a guess, but also unsure. I opened a ticket here to investigate on the wallet side: #37303 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| private readonly multichainTokenListButton = { | ||
| testId: 'multichain-token-list-button', | ||
| }; |
There was a problem hiding this comment.
Bug: Invalid Selector Format Causes Runtime Failures
The multichainTokenListButton selector uses an invalid format. It's defined as { testId: 'multichain-token-list-button' }, but the driver's waitForSelector method doesn't recognize the testId property. It should be formatted as a string selector '[data-testid="multichain-token-list-button"]' to match the existing pattern in this class (see tokenListItem at line 106-107). This will cause runtime failures when waitForSelector(this.multichainTokenListButton) is called in the import methods.
Member
Author
There was a problem hiding this comment.
mmm this is not correct 🤔 passing a test id key like this as a selector, does work. @HowardBraham added the logic for it here:
https://github.com/MetaMask/metamask-extension/blob/main/test/e2e/webdriver/driver.js#L238
seaona
changed the title
Token List Sorting should sort tokens alphabetically and by decreasing balanceToken List..., Token Details, Send ERC20because they broke with error can't convert undefined to object
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [5c4023d]
UI Startup Metrics (1205 ± 112 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
chloeYue
approved these changes
Oct 28, 2025
Contributor
chloeYue
left a comment
chloeYue
left a comment
There was a problem hiding this comment.
the fix looks good to me !
jvbriones
approved these changes
Oct 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following specs are flaky at the same point:
If we login to the Homepage and very fast click Import, the wallet breaks with the error
can't convert undefined to object. This is a race condition on the wallet side (issue here).However, we can fix the test by waiting deterministically for the multichain asset list (whichever we have) to be loaded, before clicking import. This solves the issue and it's mitigated on the page class, so all tests are indirectly more stable because of this now.
See repro:
broken-import.mov
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Ensure e2e token import flows wait for the multichain asset list to load to reduce flakiness.
multichainTokenListButtonselector.multichainTokenListButtonbefore initiating import flows inimportCustomTokenByChain,importTokenBySearch, andimportMultipleTokensBySearchto ensure asset list is loaded.Written by Cursor Bugbot for commit 5c4023d. This will update automatically on new commits. Configure here.