feat: release sidepanel #37304
Merged
feat: release sidepanel #37304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [d7419ea]
UI Startup Metrics (1256 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [174fe3a]
UI Startup Metrics (1284 ± 83 ms)
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [d1ebf0c]
UI Startup Metrics (1260 ± 81 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [9d07da2]
UI Startup Metrics (1164 ± 104 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [7c4c440]
UI Startup Metrics (1289 ± 104 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [01a77b2]
UI Startup Metrics (1281 ± 77 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [6efcfb7]
UI Startup Metrics (1285 ± 100 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
I can't tell if it's related to this PR but I get a hanging confirmation screen when trying to add different evm networks, e.g.
The same steps on popup don't result in the spinner. |
n3ps
previously approved these changes
Nov 13, 2025
Member
Author
Great Catch, @ameliejyc. This happened because recently a race condition was introduced in the confirmations screen. Since the tests operate in popup view we were not able to catch it. Since, in the popup view The |
NidhiKJha
commented
Nov 13, 2025
Comment on lines
+238
to
+245
| await onAddEthereumChain(); | ||
| history.push(DEFAULT_ROUTE); | ||
| } else if (isTransactionConfirmation) { | ||
| onTransactionConfirm(); | ||
| await onTransactionConfirm(); | ||
| navigateNext(currentConfirmation.id); | ||
| } else { | ||
| dispatch(resolvePendingApproval(currentConfirmation.id, undefined)); | ||
| await dispatch(resolvePendingApproval(currentConfirmation.id, undefined)); | ||
| navigateNext(currentConfirmation.id); |
Member
Author
There was a problem hiding this comment.
Prevents race condition where navigation happens before approval completes, causing spinner to hang in sidepanel.
Collaborator
Builds ready [335360d]
UI Startup Metrics (1221 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e88b985]
UI Startup Metrics (1234 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
force-pushed
the
sidebar-e2e
branch
from
7a7d64b to
8b135a2
Compare
Collaborator
Builds ready [0ed9cd2]
UI Startup Metrics (1208 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
approved these changes
Nov 13, 2025
Member
chaitanyapotti
left a comment
chaitanyapotti
left a comment
There was a problem hiding this comment.
nit: we're no longer using code fences but instead using env variables
lgtm on onboarding changes
NidhiKJha
commented
Nov 13, 2025
Comment on lines
+40
to
+44
| await driver.driver.get(`${driver.extensionUrl}/home.html`); | ||
|
|
||
| // Wait for the home page to fully load | ||
| await driver.waitForSelector('[data-testid="account-menu-icon"]'); | ||
| } |
Member
Author
There was a problem hiding this comment.
Will update it to use helper function for page loading in a separate PR
pnarayanaswamy
approved these changes
Nov 13, 2025
jpuri
approved these changes
Nov 13, 2025
Contributor
jpuri
left a comment
jpuri
left a comment
There was a problem hiding this comment.
Changes in files owned by confirmations look good 👍
metamaskbot
added
the
release-13.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to release sidepanel feature in main
Description
This PR is to introduce sidepanel
Changelog
CHANGELOG entry: Introduced sidepanel
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Enables the side panel experience across builds with new permissions/manifests, feature-gated logic, updated global menu/onboarding/confirmations flows, and comprehensive test adjustments, plus new i18n strings.
getIsSidePanelFeatureEnabled+ newuseSidePanelEnabled(build flag + remote flag + API presence).IS_SIDEPANEL: trueformain,beta, andflaskinbuilds.yml.browser.sidePanelexists.tabs,sidePanel,contextMenuspermissions; Chromeside_panelwithsidepanel.html.handleSidepanelPostOnboardinghelper; integrate across onboarding, privacy, metrics, network, reset, and dapp tests.IS_SIDEPANELin test env.metamaskExtension,openFullScreen,switchToPopup,switchToSidePanel(en/en_GB); remove legacyexpandView,popupView,sidePanelViewacross locales.Written by Cursor Bugbot for commit 0ed9cd2. This will update automatically on new commits. Configure here.